#27 make TxMessage data members public #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marius-meissner
requested changes
Sep 24, 2024
There was a problem hiding this comment.
I don't think it's worth giving up OOP or stability and security principles just because of tests.
What about just adding getter methods, which return immutable borrows?
This would also have the advantage that these methods may also be helpful outside of tests.
Yes probably a better idea, so as an example to get the buff member we could implement a fn like this: pub fn get_payload(&self) -> &Bytes {
&self.buff
} |
| @@ -111,3 +111,15 @@ fn test_payload_greater_than_generic_type_args() { | |||
| assert_eq!(message_2_0.unwrap_err(), MessageError::InvalidLength(5)); | |||
| assert_eq!(message_fd.unwrap_err(), MessageError::InvalidLength(23)); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
Even with unit test, nice :) 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #27