Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TxMessage data members to public #27

Closed
HusseinAbdelhamid opened this issue Sep 24, 2024 · 0 comments · Fixed by #28
Closed

Change TxMessage data members to public #27

HusseinAbdelhamid opened this issue Sep 24, 2024 · 0 comments · Fixed by #28
Assignees
@HusseinAbdelhamid

Comments

@HusseinAbdelhamid
Copy link
Contributor

For testing purposes in BMS, it would be easier to have access to TxMessage data members to assert expected values for the message header and payload.
@HusseinAbdelhamid HusseinAbdelhamid self-assigned this Sep 24, 2024
HusseinAbdelhamid added a commit that referenced this issue Sep 24, 2024
@HusseinAbdelhamid
#27 make TxMessage data members public
ee96a27
@HusseinAbdelhamid HusseinAbdelhamid mentioned this issue Sep 24, 2024
Merged
@HusseinAbdelhamid HusseinAbdelhamid linked a pull request Sep 24, 2024 that will close this issue
#27 make TxMessage data members public #28
Merged
HusseinAbdelhamid added a commit that referenced this issue Sep 25, 2024
@HusseinAbdelhamid
#27 use getters to get message payload and header
84e101c
HusseinAbdelhamid added a commit that referenced this issue Sep 25, 2024
@HusseinAbdelhamid
#27 apply clippy fix
bb4050f
marius-meissner added a commit that referenced this issue Sep 26, 2024
@marius-meissner
Merge pull request #28 from atlas-aero/27-change-txmessage-data-membe…
8885078 
…rs-to-public

#27 make TxMessage data members public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HusseinAbdelhamid HusseinAbdelhamid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#27 make TxMessage data members public atlas-aero/rt-mcp2517
1 participant
@HusseinAbdelhamid