Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testimonials alignment on the What the experts are saying section #3501

Closed
wants to merge 1 commit into from
Closed

fix: testimonials alignment on the What the experts are saying section #3501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions pages/[lang]/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,38 +192,38 @@ export default function HomePage() {
<SupportUs className='mt-4' showSupportBanner={false} />
</Container>
<Container className='mt-8 pb-20 text-center' wide as='section'>
<Heading level={HeadingLevel.h3} typeStyle={HeadingTypeStyle.lg} className='mb-4'>
<Heading level={HeadingLevel.h3} typeStyle={HeadingTypeStyle.lg} className='mb-8'>
{t('testimonials.title')}
</Heading>
<ul className='mx-auto max-w-screen-xl md:grid md:grid-cols-2 md:px-6 lg:px-8'>
<ul className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'>
<Testimonial
className='md:pr-10 lg:pr-16'
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow'
text='Microservices underline the need for event-based communication in distributed architectures. AsyncAPI brings the richness of the REST API ecosystem to asynchronous APIs.'
authorAvatar='/img/testimonials/matt-mclarty.jpg'
authorName='Matt McLarty'
authorDescription='Global Leader of API Strategy at MuleSoft'
/>
<Testimonial
className='md:pl-10 lg:pl-16'
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow'
text='Event-driven APIs need love too! AsyncAPI brings the many benefits of a machine/human-readable specification to these nuanced approaches.'
authorAvatar='/img/testimonials/bill-doerrfeld.jpg'
authorName='Bill Doerrfeld'
authorDescription='Editor in Chief at Nordic APIs'
/>
<Testimonial
className='md:pr-10 lg:pr-16'
text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality."
authorAvatar='/img/testimonials/jonathan-schabowsky.jpg'
authorName='Jonathan Schabowsky'
authorDescription='Sr. Architect, Office of the CTO at Solace'
/>
<Testimonial
className='md:pl-10 lg:pl-16'
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow'
text='We’ve been focusing on event-driven APIs since 2014 and thank the AsyncAPI contributors every day for driving the community towards common standards.'
authorAvatar='/img/testimonials/eric-horesnyi.jpg'
authorName='Eric Horesnyi'
authorDescription='CEO at Streamdata.io'
/>
<Testimonial
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow col-span-full'
text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality."
authorAvatar='/img/testimonials/jonathan-schabowsky.jpg'
authorName='Jonathan Schabowsky'
authorDescription='Sr. Architect, Office of the CTO at Solace'
/>
Comment on lines +198 to +226
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance accessibility for testimonials section

Consider adding ARIA attributes to improve screen reader experience.

-          <ul className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'>
+          <ul 
+            className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'
+            role="list"
+            aria-label="Customer testimonials"
+          >
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<ul className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'>
<Testimonial
className='md:pr-10 lg:pr-16'
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow'
text='Microservices underline the need for event-based communication in distributed architectures. AsyncAPI brings the richness of the REST API ecosystem to asynchronous APIs.'
authorAvatar='/img/testimonials/matt-mclarty.jpg'
authorName='Matt McLarty'
authorDescription='Global Leader of API Strategy at MuleSoft'
/>
<Testimonial
className='md:pl-10 lg:pl-16'
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow'
text='Event-driven APIs need love too! AsyncAPI brings the many benefits of a machine/human-readable specification to these nuanced approaches.'
authorAvatar='/img/testimonials/bill-doerrfeld.jpg'
authorName='Bill Doerrfeld'
authorDescription='Editor in Chief at Nordic APIs'
/>
<Testimonial
className='md:pr-10 lg:pr-16'
text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality."
authorAvatar='/img/testimonials/jonathan-schabowsky.jpg'
authorName='Jonathan Schabowsky'
authorDescription='Sr. Architect, Office of the CTO at Solace'
/>
<Testimonial
className='md:pl-10 lg:pl-16'
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow'
text='We’ve been focusing on event-driven APIs since 2014 and thank the AsyncAPI contributors every day for driving the community towards common standards.'
authorAvatar='/img/testimonials/eric-horesnyi.jpg'
authorName='Eric Horesnyi'
authorDescription='CEO at Streamdata.io'
/>
<Testimonial
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow col-span-full'
text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality."
authorAvatar='/img/testimonials/jonathan-schabowsky.jpg'
authorName='Jonathan Schabowsky'
authorDescription='Sr. Architect, Office of the CTO at Solace'
/>
<ul
className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'
role="list"
aria-label="Customer testimonials"
>
<Testimonial
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow'
text='Microservices underline the need for event-based communication in distributed architectures. AsyncAPI brings the richness of the REST API ecosystem to asynchronous APIs.'
authorAvatar='/img/testimonials/matt-mclarty.jpg'
authorName='Matt McLarty'
authorDescription='Global Leader of API Strategy at MuleSoft'
/>
<Testimonial
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow'
text='Event-driven APIs need love too! AsyncAPI brings the many benefits of a machine/human-readable specification to these nuanced approaches.'
authorAvatar='/img/testimonials/bill-doerrfeld.jpg'
authorName='Bill Doerrfeld'
authorDescription='Editor in Chief at Nordic APIs'
/>
<Testimonial
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow'
text='We've been focusing on event-driven APIs since 2014 and thank the AsyncAPI contributors every day for driving the community towards common standards.'
authorAvatar='/img/testimonials/eric-horesnyi.jpg'
authorName='Eric Horesnyi'
authorDescription='CEO at Streamdata.io'
/>
<Testimonial
className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow col-span-full'
text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality."
authorAvatar='/img/testimonials/jonathan-schabowsky.jpg'
authorName='Jonathan Schabowsky'
authorDescription='Sr. Architect, Office of the CTO at Solace'
/>

</ul>
</Container>
</main>
Expand Down
Loading