fix: testimonials alignment on the What the experts are saying section #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kalprajsinh
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request focuses on improving the testimonials section of the homepage by enhancing its layout and styling. The changes include adjusting the grid layout, standardizing the appearance of testimonial components, and modifying spacing and visual elements. A new testimonial from Jonathan Schabowsky has been added, replacing the previous entry, and the overall design has been refined to create a more consistent and visually appealing presentation. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Kalprajsinh
changed the title
Kalprajsinh
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
pages/[lang]/index.tsx (3)
198-198: LGTM: Responsive grid layout with a minor enhancement suggestionThe responsive grid layout effectively handles different screen sizes. Consider adding hover states to enhance interactivity.
- <ul className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'> + <ul className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8 [&>li:hover]:scale-105 [&>li]:transition-transform'>
200-200: Complete the shadow transition effectThe
transition-shadowclass is defined but no hover state is implemented to utilize this transition.- className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' + className='p-6 bg-white shadow-md hover:shadow-xl border-t rounded-lg transition-shadow'Also applies to: 207-207, 214-214, 221-221
220-226: Enhance visual hierarchy of the highlighted testimonialWhile the testimonial spans full width, consider additional visual enhancements to better distinguish it as a featured testimonial.
- className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow col-span-full' + className='p-6 bg-white shadow-lg border-t-2 border-t-primary-500 rounded-lg transition-shadow col-span-full md:p-8'
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/[lang]/index.tsx(1 hunks)
🔇 Additional comments (1)
pages/[lang]/index.tsx (1)
195-195: LGTM: Improved heading spacing
The increased margin provides better visual separation between the heading and testimonials section.
Comment on lines
+198
to
+226
| <ul className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'> | ||
| <Testimonial | ||
| className='md:pr-10 lg:pr-16' | ||
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' | ||
| text='Microservices underline the need for event-based communication in distributed architectures. AsyncAPI brings the richness of the REST API ecosystem to asynchronous APIs.' | ||
| authorAvatar='/img/testimonials/matt-mclarty.jpg' | ||
| authorName='Matt McLarty' | ||
| authorDescription='Global Leader of API Strategy at MuleSoft' | ||
| /> | ||
| <Testimonial | ||
| className='md:pl-10 lg:pl-16' | ||
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' | ||
| text='Event-driven APIs need love too! AsyncAPI brings the many benefits of a machine/human-readable specification to these nuanced approaches.' | ||
| authorAvatar='/img/testimonials/bill-doerrfeld.jpg' | ||
| authorName='Bill Doerrfeld' | ||
| authorDescription='Editor in Chief at Nordic APIs' | ||
| /> | ||
| <Testimonial | ||
| className='md:pr-10 lg:pr-16' | ||
| text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality." | ||
| authorAvatar='/img/testimonials/jonathan-schabowsky.jpg' | ||
| authorName='Jonathan Schabowsky' | ||
| authorDescription='Sr. Architect, Office of the CTO at Solace' | ||
| /> | ||
| <Testimonial | ||
| className='md:pl-10 lg:pl-16' | ||
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' | ||
| text='We’ve been focusing on event-driven APIs since 2014 and thank the AsyncAPI contributors every day for driving the community towards common standards.' | ||
| authorAvatar='/img/testimonials/eric-horesnyi.jpg' | ||
| authorName='Eric Horesnyi' | ||
| authorDescription='CEO at Streamdata.io' | ||
| /> | ||
| <Testimonial | ||
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow col-span-full' | ||
| text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality." | ||
| authorAvatar='/img/testimonials/jonathan-schabowsky.jpg' | ||
| authorName='Jonathan Schabowsky' | ||
| authorDescription='Sr. Architect, Office of the CTO at Solace' | ||
| /> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Enhance accessibility for testimonials section
Consider adding ARIA attributes to improve screen reader experience.
- <ul className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'>
+ <ul
+ className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'
+ role="list"
+ aria-label="Customer testimonials"
+ >📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <ul className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8'> | |
| <Testimonial | |
| className='md:pr-10 lg:pr-16' | |
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' | |
| text='Microservices underline the need for event-based communication in distributed architectures. AsyncAPI brings the richness of the REST API ecosystem to asynchronous APIs.' | |
| authorAvatar='/img/testimonials/matt-mclarty.jpg' | |
| authorName='Matt McLarty' | |
| authorDescription='Global Leader of API Strategy at MuleSoft' | |
| /> | |
| <Testimonial | |
| className='md:pl-10 lg:pl-16' | |
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' | |
| text='Event-driven APIs need love too! AsyncAPI brings the many benefits of a machine/human-readable specification to these nuanced approaches.' | |
| authorAvatar='/img/testimonials/bill-doerrfeld.jpg' | |
| authorName='Bill Doerrfeld' | |
| authorDescription='Editor in Chief at Nordic APIs' | |
| /> | |
| <Testimonial | |
| className='md:pr-10 lg:pr-16' | |
| text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality." | |
| authorAvatar='/img/testimonials/jonathan-schabowsky.jpg' | |
| authorName='Jonathan Schabowsky' | |
| authorDescription='Sr. Architect, Office of the CTO at Solace' | |
| /> | |
| <Testimonial | |
| className='md:pl-10 lg:pl-16' | |
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' | |
| text='We’ve been focusing on event-driven APIs since 2014 and thank the AsyncAPI contributors every day for driving the community towards common standards.' | |
| authorAvatar='/img/testimonials/eric-horesnyi.jpg' | |
| authorName='Eric Horesnyi' | |
| authorDescription='CEO at Streamdata.io' | |
| /> | |
| <Testimonial | |
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow col-span-full' | |
| text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality." | |
| authorAvatar='/img/testimonials/jonathan-schabowsky.jpg' | |
| authorName='Jonathan Schabowsky' | |
| authorDescription='Sr. Architect, Office of the CTO at Solace' | |
| /> | |
| <ul | |
| className='mx-auto grid max-w-screen-xl gap-8 md:grid-cols-2 lg:grid-cols-3 md:px-6 lg:px-8' | |
| role="list" | |
| aria-label="Customer testimonials" | |
| > | |
| <Testimonial | |
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' | |
| text='Microservices underline the need for event-based communication in distributed architectures. AsyncAPI brings the richness of the REST API ecosystem to asynchronous APIs.' | |
| authorAvatar='/img/testimonials/matt-mclarty.jpg' | |
| authorName='Matt McLarty' | |
| authorDescription='Global Leader of API Strategy at MuleSoft' | |
| /> | |
| <Testimonial | |
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' | |
| text='Event-driven APIs need love too! AsyncAPI brings the many benefits of a machine/human-readable specification to these nuanced approaches.' | |
| authorAvatar='/img/testimonials/bill-doerrfeld.jpg' | |
| authorName='Bill Doerrfeld' | |
| authorDescription='Editor in Chief at Nordic APIs' | |
| /> | |
| <Testimonial | |
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow' | |
| text='We've been focusing on event-driven APIs since 2014 and thank the AsyncAPI contributors every day for driving the community towards common standards.' | |
| authorAvatar='/img/testimonials/eric-horesnyi.jpg' | |
| authorName='Eric Horesnyi' | |
| authorDescription='CEO at Streamdata.io' | |
| /> | |
| <Testimonial | |
| className='p-6 bg-white shadow-md border-t rounded-lg transition-shadow col-span-full' | |
| text="Developers need to be able to quickly and consistently create event-driven applications that provide business value and react to customer needs in realtime. I can't count how many times I've heard developers ask for OpenAPI/Swagger style tools for the asynchronous and event-driven world, and that is exactly what the AsyncAPI initiative is making a reality." | |
| authorAvatar='/img/testimonials/jonathan-schabowsky.jpg' | |
| authorName='Jonathan Schabowsky' | |
| authorDescription='Sr. Architect, Office of the CTO at Solace' | |
| /> |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3501--asyncapi-website.netlify.app/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3501 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 575 575
Misses 89 89 ☔ View full report in Codecov by Sentry. |
|
The previous design looks more uniform as compared to this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before
After
Related issue(s)
Fixes #3487
Fixes #3498
Summary by CodeRabbit
New Features
Improvements
Bug Fixes