(WIP) Add tck tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsyncAPI Object AsyncAPI Version String Contact Object Identifier Info Object License Object Servers Object
Server Object Server Variable Object Channels Object
Channel Item Object Operation Object Operation Trait Object
Channel Bindings Object Message Bindings Object Operation Bindings Object Parameter Object Parameters Object Server Bindings Object
Message Object
External Documentation Object Message Trait Object Tag Object
Correlation ID Object Security Requirement Object Security Scheme Object Specification Extensions
This was referenced Feb 26, 2020
fmvilas
requested changes
Mar 3, 2020
There was a problem hiding this comment.
Great stuff, @jstoiko 👏
I left some comments. In many cases, test files are too large containing irrelevant information for the test that could be avoided. It's been the reason for many of the mistakes. We should aim for the minimum needed to test that a specific thing is failing. What do you think?
Also, I'd not add more tests to this PR. Let's fix the existing ones and merge the PR. We can then iterate in smaller chunks 😅
tests/asyncapi-2.0/AsyncAPI Version String/valid-major-minor.yaml
Outdated
Show resolved
Hide resolved
tests/asyncapi-2.0/Channel Bindings Object/amqp/invalid-exchange-name-length.yaml.yaml
Show resolved
Hide resolved
tests/asyncapi-2.0/Channel Bindings Object/amqp/invalid-queue-name-length.yaml
Show resolved
Hide resolved
tests/asyncapi-2.0/Channel Bindings Object/ws/invalid-extra-properties.yaml
Outdated
Show resolved
Hide resolved
tests/asyncapi-2.0/Message Trait Object/invalid-defines-traits.yaml
Outdated
Show resolved
Hide resolved
tests/asyncapi-2.0/Message Trait Object/invalid-duplicate-tags.yaml
Outdated
Show resolved
Hide resolved
tests/asyncapi-2.0/Message Trait Object/invalid-headers-type.yaml
Outdated
Show resolved
Hide resolved
tests/asyncapi-2.0/Parameters Object/invalid-not-matching-param-name.yaml
Outdated
Show resolved
Hide resolved
|
@fmvilas thanks for the review! I've fixed most of issues you reported and left responses to some of your comments. |
fmvilas
approved these changes
Mar 19, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use make (on MacOS, upgrade to gmake:
brew install gmake) to run the tests and generate a HTML report:After adding, moving or deleting TCK test files, the manifest needs to be regenerated for the tests to be visible in the report:
Parsers currently being tested are
amf-client-jsandasyncapi-parser.After PR is merged:
add_tck_testsbranch withmaster