Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should defaultContentType have a default? #319

Open
fmvilas opened this issue Mar 3, 2020 · 5 comments
Open

Should defaultContentType have a default? #319

fmvilas opened this issue Mar 3, 2020 · 5 comments
Assignees
Labels
🐞 Bug keep-open Prevents stale bot from closing this issue or PR

Comments

@fmvilas
Copy link
Member

fmvilas commented Mar 3, 2020

defaultContentType doesn't have a default value and it's not listed on the AsyncAPI Object, even though it's at root level and must be there.

Should we make this field mandatory or have a default value of, for example, application/json?

Thanks, @jstoiko for your work on the TCK, it helped raise the issue.

@derberg
Copy link
Member

derberg commented Mar 3, 2020

I don't think it should be mandatory,
it for sure should have a default and best would be application/json
this is how I would expect default to work, not see him but have him, and only write explicitly if I want to change it

@jonaslagoni
Copy link
Member

I agree with @derberg, like the idea of keeping the AsyncAPI file as simple as possible (default over mandatory) 👍

@fmvilas
Copy link
Member Author

fmvilas commented Mar 4, 2020

Yes, I agree too. Thanks, folks!

@fmvilas fmvilas added this to the AsyncAPI specification 2.0.1 milestone Mar 13, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label May 13, 2020
@fmvilas fmvilas added keep-open Prevents stale bot from closing this issue or PR and removed stale labels May 13, 2020
@fmvilas fmvilas modified the milestones: AsyncAPI specification 2.0.1, AsyncAPI specification 2.1.0 Jan 31, 2021
@fmvilas fmvilas removed this from the Next specification version milestone May 12, 2021
@fmvilas fmvilas added this to the 3.0.0 Release milestone Sep 14, 2021
@jonaslagoni
Copy link
Member

Is there any of you who wants to champion this? 🙂 Or can we consider this issue as needs champion? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug keep-open Prevents stale bot from closing this issue or PR
Projects
None yet
Development

No branches or pull requests

3 participants