Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compile warnings #152

Merged
merged 3 commits into from
Sep 17, 2023
Merged

fix: compile warnings #152

merged 3 commits into from
Sep 17, 2023

Commits on Jun 20, 2023

  1. build: Specified Maven Compiler Plugin version 

    It's considered a best practice to specify the Maven Plugin versions, otherwise the used version is not guaranteed and depends on the Maven release.
    Carlos Tasada committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c72fd01 View commit details
    Browse the repository at this point in the history

  2. build: Specified source encoding 

    If no source encoding is specified, Maven defaults to UTF-8, while showing a warning.

Here we specify the used format, which is UTF-8 anyway
    Carlos Tasada committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9b68046 View commit details
    Browse the repository at this point in the history

  3. fix: Lombok compiler warning 

    The compilation process was complaining about not properly specified defaults.

The `asyncapi` values are supposed to be `final`, but that change breaks the
`AsyncAPI` contract usage in different ways. The alternative is to indicate
the value is the default one for the builder. This solution removes the
warning while keeping the contract expectations.
    Carlos Tasada committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    fa9124e View commit details
    Browse the repository at this point in the history