fix: compile warnings #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 20, 2023 16:09
It's considered a best practice to specify the Maven Plugin versions, otherwise the used version is not guaranteed and depends on the Maven release.
If no source encoding is specified, Maven defaults to UTF-8, while showing a warning. Here we specify the used format, which is UTF-8 anyway
The compilation process was complaining about not properly specified defaults. The `asyncapi` values are supposed to be `final`, but that change breaks the `AsyncAPI` contract usage in different ways. The alternative is to indicate the value is the default one for the builder. This solution removes the warning while keeping the contract expectations.
ctasada
requested review from
Pakisan,
asyncapi-bot-eve and
derberg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Pakisan
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AsyncAPIdidn't had proper Builder defaultsRelated issue(s)
None