feat: add spec v3 support #160
Conversation
|
SonarCloud Quality Gate failed.
|
|
@jonaslagoni @derberg here's a PR for spec v3 support in diff. It's a draft PR(right now there's no tests, and docs, etc). Please review the approach and the code changes I have made here. One question: As discussed in the meeting I had with Jonas, we aren't going to compare v2 against v3. I'm not sure what type of error do we show here? An early return? Keep in mind that this will be used by CLI, so we need to have it so that CLI is able to show the error as well. |
aayushmau5
changed the title
|
sorry for late response. so basically the diff tool purpose is to help people with review of changes that they are doing in their documents to identify breaking changes or new topics, or other things. So yeah, I think you should disallow comparing files between versions and throw error that it is technically not possible and why. Does that help? |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
@asyncapi/bounty_team |
aayushmau5
requested review from
vinitshahdeo,
onbit-uchenik,
magicmatatjahu,
derberg and
asyncapi-bot-eve
as code owners
There was a problem hiding this comment.
- for sonar cloud, just ignore: https://github.com/asyncapi/diff/blob/master/.sonarcloud.properties
- I suggest you also remove in this PR
@vinitshahdeo @onbit-uchenikfromCODEOWNERSas they anyway never contributed after creation of this project
|
|
/rtm |
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@aayushmau5 that's working out of the box with CLI right? no additional flags enablement or stuff like that? |
|
if all good them please hit |
Description
Add support for AsyncAPI v3
Related issue(s)
#154