Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncAPI spec v3 support in Diff #154

Open
5 tasks done
Tracked by #294 ...
jonaslagoni opened this issue Jun 5, 2023 · 30 comments
Open
5 tasks done
Tracked by #294 ...

AsyncAPI spec v3 support in Diff #154

jonaslagoni opened this issue Jun 5, 2023 · 30 comments
Assignees
Labels
bounty AsyncAPI Bounty enhancement New feature or request

Comments

@jonaslagoni
Copy link
Member

jonaslagoni commented Jun 5, 2023

Reason/Context

This Issue is used to track changes needed to support AsyncAPI v3. As a code owner, please edit this list of TODO tasks in order to properly track the progress 🙂 Once this issue is closed it means that v3 is now fully supported in this library.

Remaining tasks:

@jonaslagoni jonaslagoni added the enhancement New feature or request label Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@jonaslagoni
Copy link
Member Author

cc codeowners @aayushmau5 @vinitshahdeo @onbit-uchenik @magicmatatjahu @derberg

Would be really cool to have this library work out the gate when we release v3, are any of you interested in scheduling a public call specifically to discuss how to enable this?

If you have any questions about how it can be achieved or v3-specific stuff I can help answer those in the meeting to enable you to progress with this 🙂

Let me know if it has any interest.

@aayushmau5
Copy link
Member

@jonaslagoni I'll start working on this.

Would be really cool to have this library work out the gate when we release v3, are any of you interested in scheduling a public call specifically to discuss how to enable this?

Sure! I haven't particularly kept up with the new spec changes, so it would be cool to get on a call and discuss the changes that needs to be made to this library.

@jonaslagoni
Copy link
Member Author

Cool!

@aayushmau5 just let me know a date and time that fits for you and I can schedule a meeting 🙂

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Dec 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 21, 2024
@aayushmau5 aayushmau5 removed the stale label Sep 3, 2024
@aayushmau5 aayushmau5 reopened this Sep 3, 2024
@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty label Sep 16, 2024
@aeworxet
Copy link

Bounty Issue's service comment

Text labels: bounty/2024-Q4, bounty/advanced, bounty/coding
First assignment to regular contributors: 2024-09-20 00:00:00 UTC+12:00
End Of Life after: 2024-10-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Regular contributors should explain in meaningful words how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.

@aeworxet aeworxet moved this to No Assignee in Bounty Program Sep 16, 2024
@chinma-yyy
Copy link

Hi @jonaslagoni @aeworxet,
I’d like to work on this issue under the bounty program. I’ll put together a detailed approach within the next day or two and share it here.

@aayushmau5
Copy link
Member

aayushmau5 commented Sep 17, 2024

@chinma-yyy i think it's best i work on this issue here. I already had some approach and some implementation done before this issue got stale. Will need to rework those so clubbed all the issues and will fix them on one go.

@aayushmau5 aayushmau5 self-assigned this Sep 17, 2024
@aeworxet
Copy link

@aayushmau5 is an AsyncAPI Maintainer specified in https://raw.githubusercontent.com/asyncapi/community/master/MAINTAINERS.yaml, so they fall under the first category in the prioritization list.

@aeworxet
Copy link

Bounty Issue's Timeline

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-09-17 2024-10-07 2024-12-01 2024-10-27 2024-11-17 2024-12-01
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@aeworxet aeworxet moved this from No Assignee to In Progress in Bounty Program Sep 17, 2024
@imabp
Copy link
Member

imabp commented Oct 27, 2024

@aeworxet @aayushmau5 @jonaslagoni is this open...i would. like to work on this?

@aayushmau5
Copy link
Member

@imabp I'm working on this issue :)

@imabp
Copy link
Member

imabp commented Oct 27, 2024

Okay thanks for letting me know.. @aayushmau5
As I saw the draft PR submission is 27th Oct 2024, I thought, you are not having bandwidth for this.

cc: @aeworxet

@aayushmau5
Copy link
Member

@imabp Yeah, i had some work already done which got stale. I reopened it just now but yeah, i'm actively working on this issue.

@imabp
Copy link
Member

imabp commented Oct 27, 2024

do you need any help? @aayushmau5

@aayushmau5
Copy link
Member

@imabp not yet. I'll let you know once I get these changes done. Maybe you can pick up other issues for diff if you want to :)

@imabp
Copy link
Member

imabp commented Oct 27, 2024

Sure taking a look at them @aayushmau5 . I was developing Myer's Diff Algorithm, so had a chat with Souvik, he suggested me about this project. Thanks 🙏

@aeworxet
Copy link

aeworxet commented Nov 5, 2024

@aayushmau5 (githubID 54525741), please provide an update to the PR.

@aayushmau5
Copy link
Member

@aeworxet I'm done with adding support for asyncapi v3. I'm in the process of writing tests for the changes.

@aeworxet
Copy link

@aayushmau5 (githubID 54525741), please provide an update to the PR.

2 similar comments
@aeworxet
Copy link

@aayushmau5 (githubID 54525741), please provide an update to the PR.

@aeworxet
Copy link

@aayushmau5 (githubID 54525741), please provide an update to the PR.

@aayushmau5
Copy link
Member

@aeworxet I'm currently going through AsyncAPI spec v3 and adding the proper standard file for it.

@aeworxet
Copy link

@aayushmau5, are you on track to complete this Bounty Issue by 2024-12-01, or will you need an extension?

@aayushmau5
Copy link
Member

aayushmau5 commented Dec 1, 2024

Will need an extension by two weeks for updating diff for CLI

@aeworxet
Copy link

aeworxet commented Dec 2, 2024

Upon request of the AsyncAPI Maintainer, who is responsible for the resolution of the Bounty Issue from the AsyncAPI's side and is also the Bounty Program Participant (@aayushmau5 (githubID 54525741)), all remaining target dates of the Bounty Issue's Timeline are extended by two calendar weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-09-17 2024-10-07 2024-12-15 2024-11-10 2024-12-01 2024-12-15
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@aeworxet
Copy link

aeworxet commented Dec 3, 2024

@aayushmau5 (githubID 54525741), please provide an update to the PR.

@aeworxet
Copy link

The Bounty Issue's PR is approved and ready to be merged.

@aeworxet
Copy link

@aayushmau5, please confirm that the merged code is functioning as expected, both as a standalone application and when integrated into the CLI, and close the GitHub issue.

@aeworxet
Copy link

Due to miscommunication, it was unclear whether support for this functionality by the CLI is part of this Bounty Issue. It is now clear that it is, and it is currently being developed; therefore, all remaining target dates of the Bounty Issue's Timeline are extended by two calendar weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-09-17 2024-10-07 2024-12-29 2024-11-10 2024-12-01 2024-12-29
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

6 participants