feat: add convert function from 2.0.0 to 2.1.0

[magicmatatjahu]

Description

• add convert function from 2.0.0 to 2.1.0

• change the logic for convert the spec: in PR we convert the spec from all specs between input and output version, it means that for 1.2.0 to 2.1.0 we convert spec by functions which convert:

  • 1.2.0 -> 2.0.0-rc1
  • 2.0.0-rc1 -> 2.0.0-rc2
  • 2.0.0-rc2 -> 2.0.0
  • 2.0.0 -> 2.1.0

  By this we don't need logic to write function something like from2rc1to2_1_0 etc...

• added tests

Related issue(s)
Resolves #42

[github-actions]

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[jonaslagoni]

I am wondering, is it not enough that we test with streetlight?

Anything extra should be covered by unit tests.

[magicmatatjahu]

I am wondering, is it not enough that we test with streetlight?

Anything extra should be covered by unit tests.

What for example? 😄 We bump only version of spec between 2.0.0 -> 2.1.0

[derberg]

as @jonaslagoni is looking into code already, I'm here to just remind you that once we will merge this one, we need to bump it right away in the playground. We also need to discuss if we should offer automated convert from 2.0 to 2.1 as we do with 1->2

[jonaslagoni]

Think it is enough to reuse Streetlight and not the other two, as we already have them as inputs in 1.2.0 🤔

[magicmatatjahu]

@derberg As I wrote in other places, 2.1.0 has only additions so we can convert automatically :)

[jonaslagoni]

we need to bump it right away in the playground

Wouldn't the CI system take care of that? Or is it not enabled for the playground? 🤔

[derberg]

@jonaslagoni bump is not enough. Additional changes are needed to enable or disable 2.0->2.1 conversion

As I wrote in other places, 2.1.0 has only additions so we can convert automatically :)

@magicmatatjahu thanks for pointing it out, I had no idea. We can convert automatically from 1 to 2 version too. The point is not what we can do technically but what we should do from UX perspective. We need to talk and agree if we do similar modal to playground.asyncapi.io/?url=https://raw.githubusercontent.com/asyncapi/spec/master/examples/1.2.0/slack-rtm.yml or not. Good UX would be to provide such modal, with optional conversion and link to release notes, but this is just my opinion that needs to be validated. Will you drive it forward or should I?

[jonaslagoni]

LGTM 👍

[magicmatatjahu]

@derberg I can handle that :)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[asyncapi-bot]

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀