chore: update next-major-spec with master #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dec Kolakowski <[email protected]>%0ACo-authored-by: Dec Kolakowski <[email protected]>%0ACo-authored-by: Lukasz Gornicki <[email protected]>%0ACo-authored-by: ssemyonov <[email protected]>
* Update FilterPolicy config to match AWS API Currently, filterPolicy configuration outlined in this file does not match what is outlined in the AWS documentation and API - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sns-subscription.html. The `filterPolicy` should only contain the JSON policy, so no need for the `attributes` property; which in itself was confusing as the policy can apply to the message attributes or body. Further to this, this definition file was missing the `filterPolicyScope` which is needed to determine whether the user wishes to filter on the message attributes or the body. * Minor: remove redundant ref * Minor: match Pascal casing * Minor: amend casing * Match AWS API casing and fix example * Update SNS README --------- Co-authored-by: Dec Kolakowski <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
* docs: Add high throughput properties for fifo * Use enums * Add another example * Bump version --------- Co-authored-by: adam.gloyne <[email protected]>
Co-authored-by: Sergio Moya <[email protected]>%0ACo-authored-by: Lukasz Gornicki <[email protected]>
jonaslagoni
requested review from
lbroudoux,
dalelane,
GeraldLoeffler,
derberg,
fmvilas,
smoya,
char0n and
asyncapi-bot-eve
as code owners
smoya
previously approved these changes
Nov 17, 2023
|
/dnm |
|
Remember to merge this as a regular merge commit (NOT Squash) |
3 tasks
char0n
previously approved these changes
Nov 19, 2023
derberg
approved these changes
Nov 20, 2023
derberg
reviewed
Nov 20, 2023
derberg
reviewed
Nov 20, 2023
derberg
requested changes
Nov 20, 2023
jonaslagoni
commented
Nov 20, 2023
jonaslagoni
commented
Nov 20, 2023
jonaslagoni
commented
Nov 20, 2023
|
Should be all fixed now @derberg |
derberg
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates next-major-spec branch with latest master changes.
Except for the json-schema files, as they will be added here: asyncapi/spec-json-schemas#450