feat: adapt anypointmq bindings to v3 #203
Conversation
|
I'd like to try not reviewing this PR myself but instead request that my successors as code owners, namely @jestefaniaaulet and @mihaelmulesoft, review it |
|
or maybe Mihael goes by @mboss37 these days |
|
I can review it today. |
There was a problem hiding this comment.
Dear @jonaslagoni,
I see that the field name has been updated from 'url' to 'path' and 'pathname', as per your recent changes. However, I've also observed that in the YAML example for the server configuration, 'url' is still being used instead of 'path' and 'pathname'.
Could you kindly clarify if there's a particular reason for maintaining 'url' in the YAML example, despite the changes in the field names?
Thank you!
|
Hey @mboss37, For the first round of review is to focus on:
After we agree on the correct change, we can move on to:
I just didn't want to change everything at once if we didn't agree on the core changes 😄 But you are absolutely right, those should change 😄 |
jonaslagoni
changed the title
|
@mboss37 updated examples and docs where applicable. Also updated the version number to just be a feature release 🙂 |
|
@mboss37 nice to see you here 👋🏼 once this PR is merged can you @GeraldLoeffler update https://github.com/asyncapi/bindings/pull/185/files ? probably Jose should be removed as till not he never contacted the community, at least I haven't seen anything |
|
ping @mboss37 |
|
@derberg I will start updating the files next week. Was on vacation the last couple of weeks |
|
@mboss37 Any update on this? 🙏 |
|
What do we do about this one? cc @derberg |
|
@jonaslagoni sending an email for help |
There was a problem hiding this comment.
Changes reviewed. I will check as next step if pathname needs to be extended as the new anypoint MQ version 4.x had a change in the host configuration.
Anypoint MQ v3 Host Example: https://mq-eu-west-2.anypoint.mulesoft.com/api/v1
Anypoint MQ v4 Host Example: https://mq-eu-west-2.anypoint.mulesoft.com/api/v1/organizations/92761c84-fca0-4643-b18d-a70327387b43/environments/766c627c-2c10-4432-b382-31aa5405a1d6
while the first Id after organizations represents the Mulesoft Org Id and the second Id after environments the MuleSoft specific environment of the destination.
See here: https://docs.mulesoft.com/anypoint-mq-connector/4.x/anypoint-mq-connector-upgrade-migrate
|
@mboss37 thanks a lot for the review @jonaslagoni |
|
@derberg nope, got other things with higher priority right now. I personally will probably not do an update until right before release of v3. |
|
my approval does not matter here too much |
|
@mboss37 we need your approval again 🙂 |
so #225 needs to be merged to merge this one |
|
ok checking!
…On Mon, Nov 20, 2023 at 5:55 PM Jonas Lagoni ***@***.***> wrote:
@mboss37 <https://github.com/mboss37> we need your approval again 🙂
—
Reply to this email directly, view it on GitHub
<#203 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHB4GH3R4KDQHBLSA3E4MJLYFODQJAVCNFSM6AAAAAAZFHML62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJZGQ2TIMZXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
<http://www.mulesoft.com/>
Mihael Bosnjak
Technical Architect
Salesforce Office Zurich
Ernst-Nobs-Platz 1
8004 Zürich, Switzerland
M +41 (0) 79 941 84 26
<https://www.linkedin.com/company/www.mulesoft.com>
<https://twitter.com/mulesoft> <https://www.facebook.com/MuleSoft>
<https://www.youtube.com/user/mulesoftvids> We're hiring!
<http://www.mulesoft.com/careers>
*Planned time off: 03.10.2023 - 10.10.2023*
Register for our upcoming API community event.
<https://meetups.mulesoft.com/events/details/mulesoft-zurich-presents-apiforce-embrace-exchange/>
*NOTICE: This e-mail may contain confidential information. Any pricing
information contained in this communication is confidential MuleSoft
information. If you are not the addressee or the intended recipient please
do not read this e-mail and please immediately delete this e-mail message
and any attachments from your network mail system. If you are the addressee
or the intended recipient and you save or print a copy of this e-mail,
please place it in an appropriate file, depending on whether confidential
information is contained in the message, and please treat all MuleSoft
confidential information with heightened protection.*
|
|
Approval from my side is already there. Approval from @GeraldLoeffler would unblock merging |
|
@mboss37 you're approval is ok, but GH do not respect it as you did not accept invite to become maintainer in this repo. Email from GitHub probably ended up in spam folder. Just go to https://github.com/asyncapi/bindings/invitations and you should see some button to accept invite or something |
|
ok looks like I got the invite. Accepted!
…On Tue, Nov 21, 2023 at 7:04 PM Lukasz Gornicki ***@***.***> wrote:
@mboss37 <https://github.com/mboss37> you're approval is ok, but GH do
not respect it as you did not accept invite to become maintainer in this
repo. Email from GitHub probably ended up in spam folder. Just go to
https://github.com/asyncapi/bindings/invitations and you should see some
button to accept invite or something
—
Reply to this email directly, view it on GitHub
<#203 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHB4GHYRWMDSJWWPA6DMSXLYFTUK3AVCNFSM6AAAAAAZFHML62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRGQYDONRRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
<http://www.mulesoft.com/>
Mihael Bosnjak
Technical Architect
Salesforce Office Zurich
Ernst-Nobs-Platz 1
8004 Zürich, Switzerland
M +41 (0) 79 941 84 26
<https://www.linkedin.com/company/www.mulesoft.com>
<https://twitter.com/mulesoft> <https://www.facebook.com/MuleSoft>
<https://www.youtube.com/user/mulesoftvids> We're hiring!
<http://www.mulesoft.com/careers>
*Planned time off: 03.10.2023 - 10.10.2023*
Register for our upcoming API community event.
<https://meetups.mulesoft.com/events/details/mulesoft-zurich-presents-apiforce-embrace-exchange/>
*NOTICE: This e-mail may contain confidential information. Any pricing
information contained in this communication is confidential MuleSoft
information. If you are not the addressee or the intended recipient please
do not read this e-mail and please immediately delete this e-mail message
and any attachments from your network mail system. If you are the addressee
or the intended recipient and you save or print a copy of this e-mail,
please place it in an appropriate file, depending on whether confidential
information is contained in the message, and please treat all MuleSoft
confidential information with heightened protection.*
|
|
@jonaslagoni now all green, merge whenever you want |
|
/rtm |
Description
This PR adapts the anypointmq bindings to v3. This first round of review is just for the general structure changes.
TODO right before final review:
TODO after merge:
Related issue(s)
Related to #182