-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt Kafka bindings to v3 #221
Conversation
Signed-off-by: Laurent Broudoux <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spotted a few minor things we could fix, but overall this is exactly what we need
Co-authored-by: Dale Lane <[email protected]>
Co-authored-by: Dale Lane <[email protected]>
Co-authored-by: Dale Lane <[email protected]>
All good: fix the typos and apply suggestions. Thanks @dalelane, for the review. |
just make sure you target |
oh that is intentional? but not much aligned with others, eventually cc @jonaslagoni |
Both solutions are good enough to me 🤔. @derberg's solution ends up looking cleaner for maintainers. @lbroudoux suggestion seems kinda clearer for users when reaching this repo. At least for now, not sure when more spec major versions start going out.
Additionally, we will need to change the links in v2 spec that point to this repo so they point to bindings compatible with spec v2, otherwise, people will reach bindings for spec v3 instead. |
Now replaced by #226. Could you all confirm we can cancel this one? |
agreed |
Signed-off-by: Laurent Broudoux [email protected]
Description
As discussed and proposed here in issue #182, this PR:
Another PR with specific schemas for v2 and v3 is on its way on
asyncapi/spec-json-schemas
.Related issue(s)
Relates to #182