Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import the code from the self provisioning plugin #4

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

lavocatt
Copy link
Collaborator

Please check the README to se what is supported.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
src/api/apiutil/artemis_jolokia.ts Dismissed Show dismissed Hide dismissed
@lavocatt
Copy link
Collaborator Author

lavocatt commented Jul 15, 2024

@howardgao the tests are failing because the testsuite can't load the .env file do you think some configuration is missing on the github project?

edit: the file was ignored. I've added it back in the repo.

deploy.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
lavocatt added 3 commits July 19, 2024 16:51
Import the code from the self provisioning plugin at commit:
3493b2d648669d781acf91ce7ad0efc80035be66

Functioning:
yarn buid
yarn start
yarn test
yarn build-api-doc
Scripts to build & deploy the api-server onto a cluster.
The deployment uses a route to expose the port 9443 of the pod running
the express server so that any client can connect to it.
Copied from the self provisioning plugin. This should cover the basic
needs to start this repo.
Copy link
Contributor

@Msarawan Msarawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nice work Thomas!

@lavocatt lavocatt merged commit a544bb8 into artemiscloud:main Jul 29, 2024
5 checks passed
Msarawan pushed a commit to artemiscloud/activemq-artemis-self-provisioning-plugin that referenced this pull request Jul 29, 2024
This commit removes the code from the api-server. The new repository
where the code lives now is
https://github.com/artemiscloud/activemq-artemis-jolokia-api-server.

The Dockerfile got synchronized back to the one from the
console-plugin-template at commit 2b4dbe4b4313e258be1754815614cf7d47f45c11

The deploy/ folder content has been synchronized back to its state
before introducing the api-server in the project. At commit
fc70c0e.

The only difference left is that the plugin relies on the
activemq-artemis-jolokia-api-server proxy service to be there:

```
  proxy:
    - type: Service
      alias: api-server-service
      endpoint:
        type: Service
        service:
          name: activemq-artemis-jolokia-api-server
          namespace: activemq-artemis-jolokia-api-server
          port: 9443
```

Follow the updates in the Readme for more information about how to
develop and deploy now.

This work is linked to the PR that adds the jolokia-api-server code to
its own repo there
artemiscloud/activemq-artemis-jolokia-api-server#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants