Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#240] move api server to its own repo #241

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

lavocatt
Copy link
Collaborator

This commit removes the code from the api-server. The new repository where the code lives now is
https://github.com/artemiscloud/activemq-artemis-jolokia-api-server.

The Dockerfile got synchronized back to the one from the console-plugin-template at commit 2b4dbe4b4313e258be1754815614cf7d47f45c11

The deploy/ folder content has been synchronized back to its state before introducing the api-server in the project. At commit fc70c0e.

The only difference left is that the plugin relies on the activemq-artemis-jolokia-api-server proxy service to be there:

  proxy:
    - type: Service
      alias: api-server-service
      endpoint:
        type: Service
        service:
          name: activemq-artemis-jolokia-api-server
          namespace: activemq-artemis-jolokia-api-server
          port: 9443

Follow the updates in the Readme for more information about how to develop and deploy now.

This work is linked to the PR that adds the jolokia-api-server code to its own repo there
artemiscloud/activemq-artemis-jolokia-api-server#4

@lavocatt lavocatt requested review from gaohoward and Msarawan July 15, 2024 13:26
@lavocatt lavocatt force-pushed the moveapiserver branch 2 times, most recently from 8a4e883 to c3d1ad5 Compare July 15, 2024 13:45
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
api-server/openapi.yml Show resolved Hide resolved
Copy link
Collaborator

@Msarawan Msarawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lavocatt , on the Pods List page and the Broker Details page, clicking on both Edit broker and Delete broker buttons does not open the editors and the delete modal pages. Instead, the below error message is displayed.
Screenshot from 2024-07-19 21-14-51

gaohoward
gaohoward previously approved these changes Jul 24, 2024
@gaohoward
Copy link
Collaborator

I approved on my side leaving @Msarawan for the issues she found.

This commit removes the code from the api-server. The new repository
where the code lives now is
https://github.com/artemiscloud/activemq-artemis-jolokia-api-server.

The Dockerfile got synchronized back to the one from the
console-plugin-template at commit 2b4dbe4b4313e258be1754815614cf7d47f45c11

The deploy/ folder content has been synchronized back to its state
before introducing the api-server in the project. At commit
fc70c0e.

The only difference left is that the plugin relies on the
activemq-artemis-jolokia-api-server proxy service to be there:

```
  proxy:
    - type: Service
      alias: api-server-service
      endpoint:
        type: Service
        service:
          name: activemq-artemis-jolokia-api-server
          namespace: activemq-artemis-jolokia-api-server
          port: 9443
```

Follow the updates in the Readme for more information about how to
develop and deploy now.

This work is linked to the PR that adds the jolokia-api-server code to
its own repo there
artemiscloud/activemq-artemis-jolokia-api-server#4
@lavocatt
Copy link
Collaborator Author

Hello @lavocatt , on the Pods List page and the Broker Details page, clicking on both Edit broker and Delete broker buttons does not open the editors and the delete modal pages. Instead, the below error message is displayed. Screenshot from 2024-07-19 21-14-51

Thanks a lot for catching this!
While upgrading the console to 1.4.0 the toggle-kebab was removed. We also don't need the onFocus function anymore.
It's fixed. can you have another look at the PR please @Msarawan ?

Copy link
Collaborator

@Msarawan Msarawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work Thomas.

@Msarawan Msarawan merged commit f1ea8db into artemiscloud:main Jul 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants