Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Enhance Num<Fr> testing #563

Merged
merged 2 commits into from
Nov 10, 2023
Merged

test: Enhance Num<Fr> testing #563

merged 2 commits into from
Nov 10, 2023

Conversation

huitseeker
Copy link
Contributor

  • Enhanced property testing coverage and introduced new tests for U64 and Scalar types.
  • Provided comprehensive test scenarios including basic operations, assertions, checking sign, and "lesser" properties.
  • Improved coverage for scalars and u64, encompassing overflow/underflow cases and edge conditions.

Closes #52

@huitseeker huitseeker requested a review from a team as a code owner July 25, 2023 00:58
@huitseeker huitseeker force-pushed the num_tests branch 2 times, most recently from 0ad5a24 to 6275c2a Compare July 25, 2023 12:56
@huitseeker huitseeker force-pushed the num_tests branch 3 times, most recently from 147eb1c to c64a96a Compare August 16, 2023 00:36
@huitseeker huitseeker force-pushed the num_tests branch 2 times, most recently from c53c0a7 to 5c328a6 Compare October 12, 2023 15:33
@huitseeker huitseeker mentioned this pull request Oct 12, 2023
Merged
gabriel-barrett
gabriel-barrett previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@gabriel-barrett gabriel-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@huitseeker huitseeker mentioned this pull request Oct 31, 2023
Open
@huitseeker huitseeker force-pushed the num_tests branch 2 times, most recently from 35f739f to 51c3a08 Compare November 8, 2023 00:16
@huitseeker
test: Enhance Num<Fr> testing
f5c1fef 
- Enhanced property testing coverage and introduced new tests for `U64` and `Scalar` types.
- Provided comprehensive test scenarios including basic operations, assertions, checking sign, and "lesser" properties.
- Improved coverage for scalars and u64, encompassing overflow/underflow cases and edge conditions.

Closes argumentcomputer#52
@huitseeker
refactor: Refine numeric comparison in prop_lesser function
7220306 
- add a direct comparison from argumentcomputer#738
arthurpaulino
arthurpaulino approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@arthurpaulino arthurpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@gabriel-barrett gabriel-barrett added this pull request to the merge queue Nov 10, 2023
Merged via the queue into argumentcomputer:main with commit fe70ad3 Nov 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-barrett gabriel-barrett gabriel-barrett approved these changes

@arthurpaulino arthurpaulino arthurpaulino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create more/better arithmetic tests for Num.
3 participants
@huitseeker @arthurpaulino @gabriel-barrett