Slot allocation of bit decomposition #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
reviewed
Oct 12, 2023
| ); | ||
| } | ||
| let AllocatedVal::Boolean(lt) = lt else { panic!("Expected boolean") }; | ||
| // To find out whether a < b, we will use the following reasoning: |
There was a problem hiding this comment.
@gabriel-barrett Since I have you here, perhaps you'd care to give a review to #563 ?
There was a problem hiding this comment.
My point being that it informs details and limitations of the less_than semantics.
There was a problem hiding this comment.
and I've added the final comparison to these tests.
gabriel-barrett
force-pushed
the
lem-bitdecomp
branch
from
abade4d
to
c598b7b
Compare
johnchandlerburnham
approved these changes
Oct 16, 2023
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Oct 16, 2023
- add a direct comparison from argumentcomputer#738
huitseeker
approved these changes
Oct 16, 2023
| ); | ||
| } | ||
| let AllocatedVal::Boolean(lt) = lt else { panic!("Expected boolean") }; | ||
| // To find out whether a < b, we will use the following reasoning: |
There was a problem hiding this comment.
and I've added the final comparison to these tests.
porcuquine
reviewed
Oct 16, 2023
| @@ -55,56 +49,56 @@ impl<F: LurkField> VarMap<Val<F>> { | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, Default)] | |||
| /// `Preimages` hold the non-deterministic advices for hashes and `Func` calls. | |||
| /// `Advices` hold the non-deterministic advices for hashes and `Func` calls. | |||
There was a problem hiding this comment.
Advices is a bit of an awkward formulation. Maybe this could be Hints?
porcuquine
approved these changes
Oct 16, 2023
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Nov 7, 2023
- add a direct comparison from argumentcomputer#738
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Nov 8, 2023
- add a direct comparison from argumentcomputer#738
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Nov 8, 2023
- add a direct comparison from argumentcomputer#738
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
* test: Enhance `Num<Fr>` testing - Enhanced property testing coverage and introduced new tests for `U64` and `Scalar` types. - Provided comprehensive test scenarios including basic operations, assertions, checking sign, and "lesser" properties. - Improved coverage for scalars and u64, encompassing overflow/underflow cases and edge conditions. Closes #52 * refactor: Refine numeric comparison in `prop_lesser` function - add a direct comparison from #738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces slot allocation for "less-than" operations with slot allocation for bit decomposition.
Slot allocating bit decomposition allows us to reuse bit decomposition in truncate operations, leading to 1k less constraints/auxiliaries