-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc upgrades #2229
Doc upgrades #2229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
As you mentioned, some images still need work.
These are the ones, where I've found issues with the dark theme:
- https://arbor--2229.org.readthedocs.build/en/2229/tutorial/network_two_cells_gap_junctions.html#
- https://arbor--2229.org.readthedocs.build/en/2229/ecosystem/index.html#simulators
- https://arbor--2229.org.readthedocs.build/en/2229/concepts/recipe.html#an-example-model
- https://arbor--2229.org.readthedocs.build/en/2229/concepts/hardware.html#hardware-context
- https://arbor--2229.org.readthedocs.build/en/2229/concepts/domdec.html#domain-decomposition
For the html based figures, it should be enough to change the text color to always be black. Maybe through some styling option specific to each div class?
The SVG figures could be fixed by setting the background to always be white. There appear to be ways to enforce this directly inside the SVG file.
Co-authored-by: Simon Frasch <[email protected]>
recipe--simulator diagram.
…oc/fix-math-and-warnings
@AdhocMan thanks for putting in the leg work and finding those issues. Should be all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now!
Fixes #2227
Fixes #2228