Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature of spike structure is lacking some explanation #2228

Closed
Helveg opened this issue Oct 18, 2023 · 3 comments · Fixed by #2229
Closed

Signature of spike structure is lacking some explanation #2228

Helveg opened this issue Oct 18, 2023 · 3 comments · Fixed by #2229
Labels

Comments

@Helveg
Copy link
Collaborator

Helveg commented Oct 18, 2023

https://docs.arbor-sim.org/en/latest/python/simulation.html#arbor.simulation.spikes is missing the closing parenthesis, and it's not clearly explained what 'source', 'gid', 'index', or 'time' are.

Edit: not actually missing a parenthesis

@Helveg Helveg added the bug label Oct 18, 2023
@Helveg Helveg changed the title Signature of spike structure is missing closing parenthesis and explanation Signature of spike structure is lacking some explanation Oct 18, 2023
@Helveg
Copy link
Collaborator Author

Helveg commented Oct 18, 2023

And when I unpack it as (source, (gid, index), time) I get not enough values to unpack (expected 3, got 2), so I suppose the signature is trying to say "source (composed of (gid, index)) and time", but that's also not clear with ('source', [('gid', '<u4'), ('index', '<u4')]), ('time', '<f8'). I'm sure this is probably a very correct numpy style array description, but it doesn't really land immediately 😅

@thorstenhater
Copy link
Contributor

thorstenhater commented Oct 19, 2023

Granted, it's kind of arcane and only rings true with numpy veterans, but it's also quite precise.
How about:

  • Source
    • gid: integer; global id of the source cell
    • lid: integer; index of the spike source on the source cell, eg the lidth detector on a cable cell.
  • Time: float; time of the spike.

Do you want to fix this or shall I give it a go?

PS: We can then deliver the correct data type specifier as a footnote.

@Helveg
Copy link
Collaborator Author

Helveg commented Oct 20, 2023

I see I'm too late! Quick work. I love the proposed changed in #2229 :)

AdhocMan added a commit that referenced this issue Dec 22, 2023
- Polish & modernise two cells + gap junction example.
- Investigate problems with mathjax
- Update spike data format docs.
- Switches theme to FURO, which is better maintained and document (like
... at all)
- with the new theme, we gain dark mode, yet we need to fix our graphics
to make it a really nice experience.

Fixes #2227 
Fixes #2228

---------

Co-authored-by: Simon Frasch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants