Error reporting improvements #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
When starting the child process fails and error reporting is enabled, report the failure to start the process as an error to AppSignal. Fixes #22.
Using `--no-log` without either `--cron` or `--heartbeat` is now a reasonable usage if `--error` is in the mix.
Add the command that was ran as the child process as a tag in the errors reported to AppSignal, and as an attribute on the log lines that are sent to AppSignal. Fixes #21.
unflxw
force-pushed
the
error-reporting-improvements
branch
from
81a3be6 to
c7cc139
Compare
Merged
tombruijn
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report error when process fails to start
When starting the child process fails and error reporting is enabled,
report the failure to start the process as an error to AppSignal.
Fixes #22.
Fix warnings to account for --error
Using
--no-logwithout either--cronor--heartbeatis now areasonable usage if
--erroris in the mix.Add command as tag for error and logs
Add the command that was ran as the child process as a tag in the
errors reported to AppSignal, and as an attribute on the log lines
that are sent to AppSignal.
Fixes #21.