Add name argument #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting the child process fails and error reporting is enabled, report the failure to start the process as an error to AppSignal. Fixes #22.
Using `--no-log` without either `--cron` or `--heartbeat` is now a reasonable usage if `--error` is in the mix.
Add the command that was ran as the child process as a tag in the errors reported to AppSignal, and as an attribute on the log lines that are sent to AppSignal. Fixes #21.
Do not allow sending both cron check-ins and heartbeat check-ins. It is unclear that an use case for this exists, and with the new name argument, both would default to being sent for the same check-in, which wouldn't be meaningful for at least one of them.
Add a positional `name` argument that is used as the identifier for check-ins, as the log group for logs, and as the action name for errors. This makes using the CLI less repetitive: ```sh // before: appsignal-wrap --api-key=... \ --cron backup \ --error backup \ --log backup \ -- ./backup.sh // after: appsignal-wrap backup --api-key=... --cron -- ./backup.sh ``` In addition, errors are now opt-out, and cron and heartbeat check-ins cannot both be used in the same invocation (as one of the two would necessarily not be correct for the same name)
tombruijn
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of the changes in #23. See branch comparison.
Disallow using both cron and heartbeat
Do not allow sending both cron check-ins and heartbeat check-ins.
It is unclear that an use case for this exists, and with the new
name argument, both would default to being sent for the same
check-in, which wouldn't be meaningful for at least one of them.
Add positional name argument
Add a positional
nameargument that is used as the identifierfor check-ins, as the log group for logs, and as the action name
for errors.
This makes using the CLI less repetitive:
In addition, errors are now opt-out, and cron and heartbeat check-ins
cannot both be used in the same invocation (as one of the two would
necessarily not be correct for the same name)