Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: open activity directly and add ignore to reduce flaky tests on CI env #603

Merged
merged 13 commits into from
Jan 19, 2024
Merged

test: open activity directly and add ignore to reduce flaky tests on CI env #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
53f7c0a
ci: use macos 13 arm64
KazuCocoa Jan 17, 2024
b764b7d
test: open activity directly
KazuCocoa Jan 17, 2024
bd90d07
test: open activity directly
KazuCocoa Jan 17, 2024
b5324c3
test: adjust activitty name
KazuCocoa Jan 17, 2024
8e11313
revert
KazuCocoa Jan 17, 2024
2150c36
do not redundant preperation
KazuCocoa Jan 17, 2024
54dd145
add ignore...
KazuCocoa Jan 17, 2024
be3de66
tweak
KazuCocoa Jan 17, 2024
fda9814
increase the timeout as slow ci
KazuCocoa Jan 17, 2024
790f4d3
tweak dialog
KazuCocoa Jan 18, 2024
6a32eae
ignore
KazuCocoa Jan 18, 2024
31214ed
ignore more
KazuCocoa Jan 18, 2024
4b06d62
ignore more
KazuCocoa Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions ...src/androidTestE2eTest/java/io/appium/uiautomator2/unittest/test/ActionsCommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,17 @@

import org.json.JSONArray;
import org.json.JSONException;
import org.junit.Ignore;
import org.junit.Test;

import io.appium.uiautomator2.model.By;
import io.appium.uiautomator2.model.Point;
import io.appium.uiautomator2.unittest.test.internal.BaseTest;
import io.appium.uiautomator2.unittest.test.internal.Response;

import static io.appium.uiautomator2.unittest.test.internal.TestUtils.waitForElement;
import static io.appium.uiautomator2.unittest.test.internal.commands.DeviceCommands.findElement;
import static io.appium.uiautomator2.unittest.test.internal.commands.DeviceCommands.performActions;
import static io.appium.uiautomator2.unittest.test.internal.commands.DeviceCommands.scrollToText;
import static io.appium.uiautomator2.unittest.test.internal.commands.ElementCommands.click;
import static io.appium.uiautomator2.unittest.test.internal.commands.ElementCommands.drag;
import static io.appium.uiautomator2.unittest.test.internal.commands.ElementCommands.fling;
Expand Down Expand Up @@ -72,22 +73,23 @@ private void verifyDragResult() {
}

private void setupDragDropView() throws JSONException {
scrollToText("Views"); // Due to 'Views' option not visible on small screen
Response response = findElement(By.accessibilityId("Views"));
clickAndWaitForStaleness(response.getElementId());
response = findElement(By.accessibilityId("Drag and Drop"));
clickAndWaitForStaleness(response.getElementId());
startActivity(".view.DragAndDropDemo");
waitForElement(By.id("io.appium.android.apis:id/drag_explanation"));
}

private void setupEditView() throws JSONException {
Response response = findElement(By.accessibilityId("App"));
clickAndWaitForStaleness(response.getElementId());
response = findElement(By.accessibilityId("Alert Dialogs"));
clickAndWaitForStaleness(response.getElementId());
response = findElement(By.accessibilityId("Text Entry dialog"));
startActivity(".app.AlertDialogSamples");
Response response = waitForElement(By.accessibilityId("Text Entry dialog"));
clickAndWaitForStaleness(response.getElementId());
}

@Override
public void launchAUT() {
// Skip some setup to avoid redundant setup.
dismissSystemAlert();
}

@Ignore("This test is not stable on CI as probably slow response. Please enable again once we move the CI instance to faster emulator one such as M1 macOS instance. Local run works.")
@Test
public void verifyDragAndDropOnAnotherElement() throws JSONException {
setupDragDropView();
Expand All @@ -110,6 +112,7 @@ public void verifyDragAndDropOnAnotherElement() throws JSONException {
verifyDragResult();
}

@Ignore("This test is not stable on CI as probably slow response. Please enable again once we move the CI instance to faster emulator one such as M1 macOS instance. Local run works.")
@Test
public void verifyTypingText() throws JSONException {
setupEditView();
Expand All @@ -131,6 +134,7 @@ public void verifyTypingText() throws JSONException {
assertThat((String) response.getValue(), equalTo("hi"));
}

@Ignore("This test is not stable on CI as probably slow response. Please enable again once we move the CI instance to faster emulator one such as M1 macOS instance. Local run works.")
@Test
public void verifyLongClickGesture() throws JSONException {
setupDragDropView();
Expand All @@ -149,6 +153,7 @@ public void verifyLongClickGesture() throws JSONException {
assertFalse(longClickResponse.isSuccessful());
}

@Ignore("This test is not stable on CI as probably slow response. Please enable again once we move the CI instance to faster emulator one such as M1 macOS instance. Local run works.")
@Test
public void verifyDragGesture() throws JSONException {
setupDragDropView();
Expand Down Expand Up @@ -194,6 +199,7 @@ public void verifyFlingGesture() throws JSONException {
assertFalse(flingResponse.isSuccessful());
}

@Ignore("This test is not stable on CI as probably slow response. Please enable again once we move the CI instance to faster emulator one such as M1 macOS instance. Local run works.")
@Test
public void verifyPinchCloseGesture() throws JSONException {
setupDragDropView();
Expand All @@ -219,6 +225,7 @@ public void verifyPinchCloseGesture() throws JSONException {
assertFalse(pinchCloseResponse.isSuccessful());
}

@Ignore("This test is not stable on CI as probably slow response. Please enable again once we move the CI instance to faster emulator one such as M1 macOS instance. Local run works.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succeeded occasionally.
https://github.com/appium/appium-uiautomator2-server/actions/runs/7553195868/job/20563530166?pr=603

@Test
public void verifyPinchOpenGesture() throws JSONException {
setupDragDropView();
Expand Down
13 changes: 8 additions & 5 deletions app/src/androidTestE2eTest/java/io/appium/uiautomator2/unittest/test/AlertCommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import io.appium.uiautomator2.unittest.test.internal.Response;
import io.netty.handler.codec.http.HttpResponseStatus;

import static io.appium.uiautomator2.unittest.test.internal.TestUtils.waitForElement;
import static io.appium.uiautomator2.unittest.test.internal.commands.DeviceCommands.acceptAlert;
import static io.appium.uiautomator2.unittest.test.internal.commands.DeviceCommands.dismissAlert;
import static io.appium.uiautomator2.unittest.test.internal.commands.DeviceCommands.findElement;
Expand All @@ -38,10 +39,8 @@
public class AlertCommandsTest extends BaseTest {

private void setupView() throws JSONException {
Response response = findElement(By.accessibilityId("App"));
clickAndWaitForStaleness(response.getElementId());
response = findElement(By.accessibilityId("Alert Dialogs"));
clickAndWaitForStaleness(response.getElementId());
startActivity(".app.AlertDialogSamples");
waitForElement(By.accessibilityId("List dialog"));
}

@Test
Expand All @@ -66,7 +65,11 @@ public void verifyDismissingAnAlertWithButton() throws JSONException {
Response response = findElement(By.accessibilityId("OK Cancel dialog with a long message"));
clickAndWaitForStaleness(response.getElementId());

response = dismissAlert("CANCEL");
if (Build.VERSION.SDK_INT > 28) {
response = dismissAlert("Cancel");
} else {
response = dismissAlert("CANCEL");
}
assertTrue(response.isSuccessful());
}

Expand Down
2 changes: 1 addition & 1 deletion app/src/androidTestE2eTest/java/io/appium/uiautomator2/unittest/test/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

public class Config {
public static final Long NETTY_STATUS_TIMEOUT = 32_000L;
public static final Long EXPLICIT_TIMEOUT = 16_000L;
public static final Long EXPLICIT_TIMEOUT = 24_000L;
public static final Long IMPLICIT_TIMEOUT = 8_000L;
public static final Long APP_LAUNCH_TIMEOUT = 32_000L;
public static final int DEFAULT_POLLING_INTERVAL = 300;
Expand Down
Loading