Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: open activity directly and add ignore to reduce flaky tests on CI env #603

Merged
merged 13 commits into from
Jan 19, 2024

Conversation

KazuCocoa
Copy link
Member

It looks like some failure occurred in the middle of setupDragDropView, so before running actual test

@@ -219,6 +218,7 @@ public void verifyPinchCloseGesture() throws JSONException {
assertFalse(pinchCloseResponse.isSuccessful());
}

@Ignore("This test is not stable on CI as probably slow response. Please enable again once we move the CI instance to faster emulator one such as M1 macOS instance. Local run works.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KazuCocoa KazuCocoa changed the title test: open activity directly test: open activity directly and add ignore Jan 17, 2024
@KazuCocoa KazuCocoa marked this pull request as ready for review January 17, 2024 09:11
@KazuCocoa
Copy link
Member Author

Hm, it looks like opening an activity itself very slowly or does not work frequently on CI. So... the root cause is a slow emulator on CI

@KazuCocoa KazuCocoa marked this pull request as draft January 17, 2024 18:57
@KazuCocoa KazuCocoa marked this pull request as ready for review January 18, 2024 21:03
@KazuCocoa
Copy link
Member Author

Ignored tests succeeded in my local but not on the CI as... maybe mostly by slow emulator. Once the m1 mac instance is stable (currently triggering the instance took much time. My another pr was not able to get the instance after 10 minutes)

@KazuCocoa KazuCocoa changed the title test: open activity directly and add ignore test: open activity directly and add ignore to reduce flaky tests on CI env Jan 18, 2024
@KazuCocoa KazuCocoa merged commit b10f7ed into master Jan 19, 2024
17 checks passed
@KazuCocoa KazuCocoa deleted the open-activity-directly branch January 19, 2024 03:26
Copy link

🎉 This PR is included in version 6.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant