Skip to content

Commit

Permalink
Remove commented out code for auto enabling sampling
Browse files Browse the repository at this point in the history
  • Loading branch information
bryn committed Oct 4, 2024
1 parent 562b7ac commit 1776e59
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions apollo-router/src/plugins/telemetry/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -286,20 +286,6 @@ impl Plugin for Telemetry {
.expect("otel error handler lock poisoned, fatal");

let mut config = init.config;
// This code would have enabled datadog agent sampling by default, but for now we will leave it as opt-in.
// If the datadog exporter is enabled then enable the agent sampler.
// If users are using otlp export then they will need to set this explicitly in their config.
//
// if config.exporters.tracing.datadog.enabled()
// && config
// .exporters
// .tracing
// .common
// .preview_datadog_agent_sampling
// .is_none()
// {
// config.exporters.tracing.common.preview_datadog_agent_sampling = Some(true);
// }
config.instrumentation.spans.update_defaults();
config.instrumentation.instruments.update_defaults();
config.exporters.logging.validate()?;
Expand Down

0 comments on commit 1776e59

Please sign in to comment.