Split the changelogs

apollographql · Oct 4, 2024 · 562b7ac · 562b7ac
1 parent 110917c
commit 562b7ac
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 15 deletions.
diff --git a/...atadog_upstream_sampling_decision_test.md → ...gesets/fix_bryn_datadog_agent_sampling.md b/...atadog_upstream_sampling_decision_test.md → ...gesets/fix_bryn_datadog_agent_sampling.md
@@ -1,11 +1,6 @@
-### Respect x-datadog-sampling-priority ([PR #6017](https://github.com/apollographql/router/pull/6017))
+### Add `preview_datadog_agent_sampling` ([PR #6017](https://github.com/apollographql/router/pull/6017))
 
-This PR consists of two fixes:
-#### Datadog priority sampling resolution is not lost.
-
-Previously a `x-datadog-sampling-priority` of `-1` would be converted to `0` for downstream requests and `2` would be converted to `1`.
-
-#### The sampler option in the `telemetry.exporters.tracing.common.sampler` is not datadog aware.
+The sampler option in the `telemetry.exporters.tracing.common.sampler` is not datadog aware.
 
 To get accurate APM metrics all spans must be sent to the datadog agent with a `psr` or `sampling.priority` attribute set appropriately to record the sampling decision.
 
@@ -24,25 +19,19 @@ telemetry:
       # Example OTLP exporter configuration
       otlp:
         enabled: true
-        # Optional batch processor setting, this will enable the batch processor to send concurrent requests in a high load scenario.
-        batch_processor:
-          max_concurrent_exports: 100
 
       # Example Datadog native exporter configuration 
       datadog:
         enabled: true
 
-        # Optional batch processor setting, this will enable the batch processor to send concurrent requests in a high load scenario.
-        batch_processor:
-          max_concurrent_exports: 100
 ```
 
 By using these options, you can decrease your Datadog bill as you will only be sending a percentage of spans from the Datadog agent to datadog. 
 
 > [!IMPORTANT]
-> Users must enable `preview_datadog_agent_sampling` to get accurate APM metrics.
+> Users must enable `preview_datadog_agent_sampling` to get accurate APM metrics. Users that have been using recent versions of the router will have to modify their configuration to retain full APM metrics. 
 
 > [!IMPORTANT]
 > Sending all spans to the datadog agent may require that you tweak the `batch_processor` settings in your exporter config. This applies to both OTLP and the Datadog native exporter.
 
-By [@BrynCooke](https://github.com/BrynCooke) in https://github.com/apollographql/router/pull/6017
+See the updated Datadog tracing documentation for more information on configuration options and their implications.
diff --git a/.changesets/fix_bryn_datadog_upstream_sampling_decision_propagation.md b/.changesets/fix_bryn_datadog_upstream_sampling_decision_propagation.md
@@ -0,0 +1,7 @@
+### Datadog priority sampling resolution is lost ([PR #6017](https://github.com/apollographql/router/pull/6017))
+
+Previously a `x-datadog-sampling-priority` of `-1` would be converted to `0` for downstream requests and `2` would be converted to `1`.
+This means that when propagating to downstream services a value of USER_REJECT would be transmitted as AUTO_REJECT.
+
+This PR fixes this by ensuring that the `x-datadog-sampling-priority` is transmitted as is to downstream services.
+