Feature/php84 compatible

.github/workflows/test.yml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest] # windows-latest, macos-latest
-        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
+        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
         include:
           - php: 7.2
             phpunit: 7
@@ -31,6 +31,10 @@ jobs:
             phpunit: 9
           - php: 8.2
             phpunit: 9
+          - php: 8.3
+            phpunit: 9
+          - php: 8.4
+            phpunit: 9            
     steps:
     - name: Checkout
       uses: actions/checkout@v3

composer.json

@@ -23,7 +23,7 @@
   },
   "require-dev": {
     "squizlabs/php_codesniffer": "^3.5",
-    "phan/phan": "5.4.2",
+    "phan/phan": "5.4.5",
     "phpunit/phpunit": "^7.5 || ^8.5 || ^9.5"
   },
   "autoload": {

src/Client.php

@@ -22,14 +22,14 @@ class Client
 {
     private static $converter;
     private static $jsonHelper;
-    public static function getConverter(Client $client = null): ConverterInterface
+    public static function getConverter(?Client $client = null): ConverterInterface
     {
         if (isset($client)) {
             return $client->localConverter;
         }
         return self::$converter;
     }
-    public static function getJsonHelper(Client $client = null): JsonHelper
+    public static function getJsonHelper(?Client $client = null): JsonHelper
     {
         if (isset($client)) {
             return $client->localJsonHelper;

src/Types/Sdk/CoreCallback.php

@@ -27,7 +27,7 @@ class CoreCallback
      * @param callable|null $onBeforeRequest Called before an API call
      * @param callable|null $onAfterRequest  Called after an API call
      */
-    public function __construct(callable $onBeforeRequest = null, callable $onAfterRequest = null)
+    public function __construct(?callable $onBeforeRequest = null, ?callable $onAfterRequest = null)
     {
         $this->onBeforeRequest = $onBeforeRequest;
         $this->onAfterRequest = $onAfterRequest;

src/Utils/XmlDeserializer.php

@@ -22,7 +22,7 @@ class XmlDeserializer
     /**
      * @param int|null $loadOptions  A bit field of LIBXML_* constants
      */
-    public function __construct(int $loadOptions = null)
+    public function __construct(?int $loadOptions = null)
     {
         $this->dom = new DOMDocument();
         $this->loadOptions = $loadOptions ?? (LIBXML_NONET | LIBXML_NOBLANKS);
@@ -81,7 +81,7 @@ public function fromElementToArray(
         \DOMNode $parent,
         string $itemName,
         string $clazz,
-        string $wrappingElementName = null
+        ?string $wrappingElementName = null
     ) {
         if ($wrappingElementName === null) {
             $elements = static::getChildNodesByTagName($parent, $itemName);

src/Utils/XmlSerializer.php

@@ -67,7 +67,7 @@ public function addArrayAsSubelement(
         \DOMNode $root,
         string $itemName,
         $items,
-        string $wrappingElementName = null
+        ?string $wrappingElementName = null
     ): void {
         if ($items === null) {
             return;
@@ -102,7 +102,7 @@ public function addAsSubelement(\DOMNode $root, string $name, $value): ?\DOMElem
         return $element;
     }
 
-    public function createElement(string $name, string $value = null): \DOMElement
+    public function createElement(string $name, ?string $value = null): \DOMElement
     {
         return $value === null ? $this->dom->createElement($name) : $this->dom->createElement($name, $value);
     }

tests/LoggerTest.php

@@ -81,7 +81,7 @@ public function testConsoleLoggerFailure()
 
     private function logAndGetEntry(
         string $level,
-        LoggerInterface $logger = null,
+        ?LoggerInterface $logger = null,
         string $message = 'someMessage',
         array $context = []
     ): LogEntry {