Feature/php84 compatible #62
Conversation
|
@dmnlk Thanks for mentioning me here, the checks for php version 8.4 are failing, we will have to look into it |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
|
@asadali214 i fixed lockfile and test code |
There was a problem hiding this comment.
These changes looks good to me!
@dmnlk thanks for contributing to apimatic/core-lib-php
This commit adds support for PHP 8.3 in CI/CD pipeline and PHP 8.4 support in all areas Co-authored-by: Asad Ali <[email protected]>
This commit adds support for PHP 8.3 in CI/CD pipeline and PHP 8.4 support in all areas Co-authored-by: Asad Ali <[email protected]> Signed-off-by: Asad Ali <[email protected]>
|
Hey @dmnlk your changes are deployed to production: https://github.com/apimatic/core-lib-php/releases/tag/0.3.12 |
What
add PHP 8.4 support
https://www.php.net/releases/8.4/en.php
Why
In PHP 8.4, when using default arguments set to null, you are required to specify a type hint that includes either nullable or a union type with null. If this is not specified, a deprecated error will be displayed starting in PHP 8.4. This change is being addressed.
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
Additionally, matrix build settings have been added to ensure the project is built across multiple PHP versions.
Closes #64
Type of change
Select multiple if applicable.
Dependency Change
If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries
Breaking change
If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries
Testing
List the steps that were taken to test the changes
Checklist