refactor: update libp2p-yamux and fix breaking changes #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paralin
force-pushed
the
update-yamux
branch
from
9e30f9d to
996e7f8
Compare
1 task
paralin
force-pushed
the
update-yamux
branch
2 times, most recently
from
cd11abb to
dbe29fa
Compare
paralin
force-pushed
the
update-yamux
branch
4 times, most recently
from
7b8b19d to
fa22db9
Compare
paralin
changed the title
paralin
force-pushed
the
update-yamux
branch
3 times, most recently
from
e02f163 to
aa52059
Compare
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
force-pushed
the
update-yamux
branch
from
aa52059 to
f0ca540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: update libp2p-yamux and fix breaking changes
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
Related: