js-libp2p-yamux 6.0.x breaks integration tests #120
Comments
paralin
added a commit
that referenced
this issue
Dec 1, 2023
NOTE: The following issues must be addressed before this is merged: libp2p/interface is currently held at version 0.1.2: - Passing a logger to MuxerInit is now required (should be optional?): libp2p/js-libp2p#2275 @chainsafe/libp2p-yamux is currently held at version 5.0.4: - Passing a logger to yamux()({logger:...}) is now required (should be optional?): ChainSafe/js-libp2p-yamux#69 - The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175 See: #120 --- Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Dec 11, 2023
NOTE: The following issues must be addressed before this is merged: libp2p/interface is currently held at version 0.1.2: - Passing a logger to MuxerInit is now required (should be optional?): libp2p/js-libp2p#2275 @chainsafe/libp2p-yamux is currently held at version 5.0.4: - Passing a logger to yamux()({logger:...}) is now required (should be optional?): ChainSafe/js-libp2p-yamux#69 - The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175 See: #120 --- Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Dec 19, 2023
See: - #120 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#71 Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Jan 10, 2024
NOTE: The following issues must be addressed before this is merged: libp2p/interface is currently held at version 0.1.2: - Passing a logger to MuxerInit is now required (should be optional?): libp2p/js-libp2p#2275 @chainsafe/libp2p-yamux is currently held at version 5.0.4: - Passing a logger to yamux()({logger:...}) is now required (should be optional?): ChainSafe/js-libp2p-yamux#69 - The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175 See: #120 --- Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Jan 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
changed the title
paralin
added a commit
that referenced
this issue
Jan 17, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Jan 17, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Feb 7, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Feb 7, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Feb 9, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
that referenced
this issue
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175
WIP commit: #121
The text was updated successfully, but these errors were encountered: