[core] Introduce AsyncPositionOutputStream #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
changed the title
tsreaper
reviewed
Aug 5, 2024
| } catch (ExecutionException e) { | ||
| throw new RuntimeException(e); | ||
| } finally { | ||
| isClosed = true; |
There was a problem hiding this comment.
What's the usage of this isClosed? The thread needs an EndEvent or isClosed == true to exit. However you use future.get() to wait for thread and then set isClosed = true, meaning that only EndEvent can stop the thread.
tsreaper
reviewed
Aug 6, 2024
| @Override | ||
| public void close() throws IOException { | ||
| checkException(); | ||
| flushBuffer(); |
There was a problem hiding this comment.
Suggested change
| flushBuffer(); | |
| flush(); |
There was a problem hiding this comment.
It is flushBuffer, close will also do inner flush too.
| private final int offset; | ||
| private final int length; | ||
|
|
||
| public DataEvent(byte[] data, int offset, int length) { |
There was a problem hiding this comment.
offset is always 0, no need for this field.
| import java.io.ByteArrayOutputStream; | ||
|
|
||
| /** A {@link ByteArrayOutputStream} which can reuse byte array. */ | ||
| public class ReuseByteArrayOutputStream extends ByteArrayOutputStream { |
There was a problem hiding this comment.
What's the usage of this class? I don't see it is used anywhere.
There was a problem hiding this comment.
Just for util usage.
tsreaper
approved these changes
Aug 6, 2024
wxplovecc
pushed a commit
to tongcheng-elong/incubator-paimon
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces asynchronous file writing to increase data throughput.
In order to avoid the problem of byte array reuse, all written arrays are copied once, which is the overhead brought by this PR. However, compared to writing files, copying a byte array seems to be less expensive.
Tests
AsyncPositionOutputStreamTestAPI and Format
Documentation