Fix version and rc in rc.yml
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
commented
Nov 13, 2024
Comment on lines
+54
to
+55
| echo "VERSION=${version}" | ||
| echo "RC=${rc}" |
There was a problem hiding this comment.
added for debugging
zeroshade
approved these changes
Nov 13, 2024
RussellSpitzer
approved these changes
Nov 13, 2024
|
Thanks @kevinjqliu for the PR and @zeroshade for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #199.
For the RC workflow running on a tag, there was an issue resulting in the wrong filename used for the
tar.gzfile, for example,apache-iceberg-go-0.1.0-rc1-rc1.tar.gz. Notice the extra-rc.This is due to the parsing logic which is fixed in this PR.
For details, see https://github.com/apache/iceberg-go/actions/runs/11821595808/job/32936689238
where the
Archivejob'sArchivestep has the followingTested in fork repo.
v0.1.0-rc1release https://github.com/kevinjqliu/iceberg-go/releases/tag/v0.1.0-rc1https://github.com/kevinjqliu/iceberg-go/actions/runs/11824564368/job/32946341965
Downloaded artifacts in https://github.com/kevinjqliu/iceberg-go/actions/runs/11824501122 and checked the sha256 file is correct