Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release_rc.sh, use the right artifact file name #203

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Nov 13, 2024

#204

While running release_rc.sh for RC2, I noticed that the .asc file was not generated.
There's a bug in the script similar to #199 and #202 where the filename does not include the RC version.

This PR fixes the script to use the correct file name, apache-iceberg-go-0.1.0-rc2.tar.gz, which corresponds with the artifacts here https://github.com/apache/iceberg-go/releases/tag/v0.1.0-rc2

Tested in terminal

version=0.1.0                            
rc=2
id="apache-iceberg-go-${version}-rc${rc}" 
tar_gz="${id}.tar.gz"
echo $tar_gz
> apache-iceberg-go-0.1.0-rc2.tar.gz

@github-actions github-actions bot added the INFRA label Nov 13, 2024
@kevinjqliu kevinjqliu changed the title use the right file name Fix release_rc.sh, use the right artifact file name Nov 13, 2024
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@kevinjqliu kevinjqliu requested a review from Fokko December 5, 2024 18:09
@kevinjqliu
Copy link
Contributor Author

@Fokko can you help with merging this pr?

@zeroshade zeroshade merged commit a701ade into apache:main Dec 12, 2024
10 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/fix-release-rc branch December 13, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants