Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](s3) improve error msg #45360

Merged
merged 2 commits into from
Dec 15, 2024
Merged

[fix](s3) improve error msg #45360

merged 2 commits into from
Dec 15, 2024

Conversation

suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Dec 12, 2024 •
edited by morningman
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@suxiaogang223
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Dec 12, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@suxiaogang223
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.75% (10104/26074)
Line Coverage: 29.68% (84762/285548)
Region Coverage: 28.74% (43499/151345)
Branch Coverage: 25.30% (22095/87340)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8d91f7835135c4e0ab4d573b4b9fc0251203f29b_8d91f7835135c4e0ab4d573b4b9fc0251203f29b/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 06efb40 into apache:master Dec 15, 2024
29 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 15, 2024
@suxiaogang223
[fix](s3) improve error msg (#45360)
774aa38
@github-actions github-actions bot mentioned this pull request Dec 15, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 15, 2024
@suxiaogang223
[fix](s3) improve error msg (#45360)
7ff164e
@github-actions github-actions bot mentioned this pull request Dec 15, 2024
Merged
yiguolei pushed a commit that referenced this pull request Dec 16, 2024
@github-actions @suxiaogang223
branch-2.1: [fix](s3) improve error msg #45360 (#45432)
23c5d52 
Cherry-picked from #45360

Co-authored-by: Socrates <[email protected]>
@suxiaogang223 suxiaogang223 deleted the imporve_error_msg branch December 16, 2024 08:15
morningman pushed a commit that referenced this pull request Dec 20, 2024
@suxiaogang223 @morningman
[fix](s3) improve error msg (#45360)
71af2d8
morningman pushed a commit that referenced this pull request Dec 20, 2024
@github-actions @suxiaogang223
branch-3.0: [fix](s3) improve error msg #45360 (#45431)
648e5dd 
Cherry-picked from #45360

Co-authored-by: Socrates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou left review comments

@wuwenchi wuwenchi wuwenchi approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@suxiaogang223 @Thearas @doris-robot @morningman @gavinchou @CalvinKirs @wuwenchi @yiguolei