Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](s3) improve error msg #45360 #45431

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45360

@Thearas
Copy link
Contributor

Thearas commented Dec 15, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 15, 2024
@Thearas
Copy link
Contributor

Thearas commented Dec 15, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40247 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 774aa388c1210151317f1876ae08822d6b8c0fe2, data reload: false

------ Round 1 ----------------------------------
q1	17572	7312	7225	7225
q2	2055	165	157	157
q3	10717	1083	1156	1083
q4	10554	738	711	711
q5	7724	2786	2735	2735
q6	232	145	143	143
q7	967	619	607	607
q8	9591	1892	1957	1892
q9	7730	6371	6327	6327
q10	6974	2308	2295	2295
q11	464	260	255	255
q12	400	210	207	207
q13	17786	2943	2968	2943
q14	238	204	206	204
q15	554	521	525	521
q16	684	619	613	613
q17	962	524	581	524
q18	7191	6498	6558	6498
q19	1862	1054	1029	1029
q20	451	198	194	194
q21	4045	3134	3242	3134
q22	1037	950	969	950
Total cold run time: 109790 ms
Total hot run time: 40247 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7304	7204	7168	7168
q2	325	232	232	232
q3	2863	2889	2810	2810
q4	1993	1843	1759	1759
q5	5680	5697	5681	5681
q6	218	138	141	138
q7	2195	1772	1800	1772
q8	3270	3553	3479	3479
q9	8710	8895	8773	8773
q10	3520	3483	3528	3483
q11	598	510	499	499
q12	779	598	606	598
q13	16549	3149	3125	3125
q14	313	280	265	265
q15	565	519	513	513
q16	724	671	675	671
q17	1845	1626	1614	1614
q18	8238	7736	7488	7488
q19	2366	1580	1522	1522
q20	2063	1857	1818	1818
q21	5471	5335	5255	5255
q22	1120	1011	1007	1007
Total cold run time: 76709 ms
Total hot run time: 59670 ms

@gavinchou
Copy link
Contributor

run p0

@morningman morningman force-pushed the auto-pick-45360-branch-3.0 branch from 774aa38 to 71af2d8 Compare December 20, 2024 01:41
@morningman
Copy link
Contributor

run buildall

Copy link
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40108 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 71af2d8a7d87821a622e6a4fce86dbc74af5acfa, data reload: false

------ Round 1 ----------------------------------
q1	17566	7349	7259	7259
q2	2060	167	166	166
q3	10736	1051	1122	1051
q4	10580	714	734	714
q5	7701	2793	2702	2702
q6	231	143	141	141
q7	952	620	618	618
q8	9569	1903	1980	1903
q9	7761	6353	6361	6353
q10	6932	2268	2261	2261
q11	442	257	253	253
q12	403	212	209	209
q13	17795	2977	3035	2977
q14	236	213	207	207
q15	560	523	519	519
q16	658	595	616	595
q17	963	554	511	511
q18	7192	6497	6625	6497
q19	2740	1051	1032	1032
q20	475	203	187	187
q21	4067	3012	2992	2992
q22	1102	992	961	961
Total cold run time: 110721 ms
Total hot run time: 40108 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7354	7223	7199	7199
q2	320	237	229	229
q3	2883	2869	2866	2866
q4	1969	1815	1739	1739
q5	5642	5667	5680	5667
q6	227	146	145	145
q7	2155	1749	1765	1749
q8	3273	3500	3424	3424
q9	8721	8720	8716	8716
q10	3514	3467	3500	3467
q11	587	501	502	501
q12	788	576	599	576
q13	16595	3114	3084	3084
q14	307	266	272	266
q15	572	510	534	510
q16	715	669	657	657
q17	1849	1629	1604	1604
q18	8188	7936	7421	7421
q19	5993	1498	1523	1498
q20	2063	1839	1832	1832
q21	5462	5355	5268	5268
q22	1125	1027	1018	1018
Total cold run time: 80302 ms
Total hot run time: 59436 ms

@morningman morningman merged commit 648e5dd into branch-3.0 Dec 20, 2024
26 of 30 checks passed
@github-actions github-actions bot deleted the auto-pick-45360-branch-3.0 branch December 20, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants