[fix]Remove be special handling of date types and bugs in registration functions #45159
+1,453
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39869 ms |
TPC-DS: Total hot run time: 197769 ms |
ClickBench: Total hot run time: 33.24 s |
|
run p0 |
zclllyybb
reviewed
Dec 10, 2024
| @@ -158,19 +167,21 @@ class SimpleFunctionFactory { | |||
| FunctionBasePtr get_function(const std::string& name, const ColumnsWithTypeAndName& arguments, | |||
| const DataTypePtr& return_type, const FunctionAttr& attr = {}, | |||
| int be_version = BeExecVersionManager::get_newest_version()) { | |||
| std::string key_str = name; | |||
| std::string key_str, ori_name = name; | |||
There was a problem hiding this comment.
split definition. use origin_name
There was a problem hiding this comment.
add comment on these two var
be/src/vec/functions/function.h
Outdated
| @@ -299,6 +299,10 @@ class FunctionBuilderImpl : public IFunctionBuilder { | |||
|
|
|||
| ColumnNumbers get_arguments_that_are_always_constant() const override { return {}; } | |||
|
|
|||
| // if a function's get_variadic_argument_types() not override and get_return_type_impl() | |||
| // result is not compile time be sure, the function should override return true | |||
| virtual bool dont_append_return_type_name_when_register_function() { return false; } | |||
There was a problem hiding this comment.
impl it in IFunctionBase, so we can do check in function factory.
if not possible, add comment.
There was a problem hiding this comment.
the register_function() arg Creator& ptr is a FunctionBuilder so cant impl it in IFunctionBase it move to IFunctionBuilder
There was a problem hiding this comment.
add regression-test about null
|
run beut |
|
run buildall |
|
run buildall |
|
TeamCity be ut coverage result: |
|
PR approved by anyone and no changes requested. |
feiniaofeiafei
approved these changes
Dec 17, 2024
|
run performance |
TPC-H: Total hot run time: 40379 ms |
TPC-DS: Total hot run time: 191119 ms |
ClickBench: Total hot run time: 32.52 s |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32789 ms |
TPC-DS: Total hot run time: 190518 ms |
ClickBench: Total hot run time: 31.32 s |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 32699 ms |
TPC-DS: Total hot run time: 196368 ms |
ClickBench: Total hot run time: 31.36 s |
|
TeamCity be ut coverage result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)