Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[only test] #45558

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[only test] #45558

wants to merge 1 commit into from

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Dec 17, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Dec 17, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.86% (10129/26066)
Line Coverage: 29.78% (85159/285921)
Region Coverage: 28.82% (43655/151469)
Branch Coverage: 25.36% (22178/87440)
Coverage Report: http://coverage.selectdb-in.cc/coverage/111bb87e45e7a60979208a9ff50de9e083b9e60c_111bb87e45e7a60979208a9ff50de9e083b9e60c/report/index.html

@Mryange Mryange force-pushed the add-return-type-round branch from 111bb87 to 6d559f1 Compare December 18, 2024 08:47
@Mryange
Copy link
Contributor Author

Mryange commented Dec 18, 2024

run buildall

Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In gensrc/script/gen_build_version.sh line 38:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.


In gensrc/script/gen_build_version.sh line 228:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.

For more information:
  https://www.shellcheck.net/wiki/SC2071 -- > is for string comparisons. Use ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.87% (10133/26067)
Line Coverage: 29.80% (85202/285914)
Region Coverage: 28.84% (43686/151475)
Branch Coverage: 25.38% (22196/87450)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6d559f1511a1a6e6b1f0f7870cc8340101aa4c27_6d559f1511a1a6e6b1f0f7870cc8340101aa4c27/report/index.html

@Mryange Mryange force-pushed the add-return-type-round branch from 6d559f1 to a1b4a8c Compare December 18, 2024 12:45
@Mryange
Copy link
Contributor Author

Mryange commented Dec 18, 2024

run buildall

Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In gensrc/script/gen_build_version.sh line 38:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.


In gensrc/script/gen_build_version.sh line 228:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.

For more information:
  https://www.shellcheck.net/wiki/SC2071 -- > is for string comparisons. Use ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.94% (10152/26068)
Line Coverage: 29.85% (85356/285973)
Region Coverage: 28.91% (43799/151507)
Branch Coverage: 25.45% (22259/87474)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a1b4a8c4bdeb85ff51ccf43ba1b024fe55ab68fa_a1b4a8c4bdeb85ff51ccf43ba1b024fe55ab68fa/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Dec 18, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.95% (10154/26068)
Line Coverage: 29.85% (85371/285973)
Region Coverage: 28.91% (43803/151507)
Branch Coverage: 25.46% (22268/87474)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a1b4a8c4bdeb85ff51ccf43ba1b024fe55ab68fa_a1b4a8c4bdeb85ff51ccf43ba1b024fe55ab68fa/report/index.html

is_decimal(func_return_type->is_nullable()
? ((DataTypeNullable*)func_return_type.get())->get_nested_type()
: func_return_type));
auto expect_return_type = remove_nullable(return_type);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants