[Fix](Variant) fix some nested explode_variant_array bug and add more… #44533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
eldenmoon
force-pushed
the
fix-variant-nested-explode
branch
from
5c60c45 to
a2a985c
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40007 ms |
TPC-DS: Total hot run time: 190830 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.22 s |
eldenmoon
force-pushed
the
fix-variant-nested-explode
branch
from
a2a985c to
fee282a
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39658 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 196719 ms |
ClickBench: Total hot run time: 32.44 s |
amorynan
reviewed
Nov 26, 2024
| // 1. array_contains | ||
| qt_sql "select * from var_nested_array_agg where array_contains(cast(v['nested']['xx'] as array<int>), 10) order by k limit 10" | ||
| // 2. array_agg scalar | ||
| sql "select k, array_agg(cast(v['nested'] as text)) from var_nested_array_agg group by k limit 10" |
There was a problem hiding this comment.
qt_sql ? just sql will not show the output in out file
There was a problem hiding this comment.
the output is not stable since the serailized v['nested'] may contains blank and is not stable， which is acceptable at present
amorynan
reviewed
Nov 26, 2024
| _array_column = ColumnNullable::create(ColumnArray::create(ColumnNothing::create(0)), | ||
| ColumnUInt8::create(0)); | ||
| _array_column->assume_mutable()->insert_many_defaults(variant_column->size()); | ||
| _detail.nested_type = std::make_shared<DataTypeNothing>(); |
There was a problem hiding this comment.
maybe here should wrap in nullable , because many calculate operator behavior just make nested column in array as nullable
There was a problem hiding this comment.
it's redundant in column object case
|
PR approved by anyone and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Dec 12, 2024
eldenmoon
added a commit
that referenced
this pull request
Dec 13, 2024
zclllyybb
reviewed
Dec 17, 2024
| @@ -37,6 +42,34 @@ VExplodeTableFunction::VExplodeTableFunction() { | |||
| _fn_name = "vexplode"; | |||
| } | |||
|
|
|||
| Status VExplodeTableFunction::_process_init_variant(Block* block, int value_column_idx) { | |||
| // explode variant array | |||
| const auto& variant_column = check_and_get_column<ColumnObject>( | |||
There was a problem hiding this comment.
here's bug which will lead to coredump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… test
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)