Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-2.1: [fix](move-memtable) immediately return error when close wait failed #44344 #44387

Merged
merged 1 commit into from
Nov 22, 2024
Merged

branch-2.1: [fix](move-memtable) immediately return error when close wait failed #44344 #44387

merged 1 commit into from
Nov 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #44344

@kaijchen
[fix](move-memtable) immediately return error when close wait failed (#…
70d0d2a 
…44344)


Problem Summary:

#38003 introduced a problem where the last sink node could report
success even when close wait timeout, which may cause data loss.

Previously we made that change hoping to tolerate minority replica
failure in this step.
However, it turns out the last sink node could miss tablet reports from
downstreams in case of close wait failure.

This PR fixes the problem by return the close_wait error immediately.
The most common error in close wait is timeout, and it should not be
fault tolerant on a replica basis anyways.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 21, 2024
@doris-robot
Copy link

run buildall

@github-actions GitHub Actions
Copy link
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.46% (9520/26113)
Line Coverage: 27.94% (78356/280434)
Region Coverage: 26.60% (40187/151098)
Branch Coverage: 23.40% (20407/87220)
Coverage Report: http://coverage.selectdb-in.cc/coverage/70d0d2a49019e1b12e7ed39e520de8541cd27e75_70d0d2a49019e1b12e7ed39e520de8541cd27e75/report/index.html

@yiguolei yiguolei merged commit d21940e into branch-2.1 Nov 22, 2024
20 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-44344-branch-2.1 branch November 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doris-robot @yiguolei @dataroaring @kaijchen