Skip to content

Commit

Permalink
branch-2.1: [fix](move-memtable) immediately return error when close …
Browse files Browse the repository at this point in the history
…wait failed #44344 (#44387)

Cherry-picked from #44344

Co-authored-by: Kaijie Chen <[email protected]>
  • Loading branch information
github-actions[bot] and kaijchen authored Nov 22, 2024
1 parent e7095ce commit d21940e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions be/src/vec/sink/writer/vtablet_writer_v2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ Status VTabletWriterV2::close(Status exec_status) {
// close_wait on all non-incremental streams, even if this is not the last sink.
// because some per-instance data structures are now shared among all sinks
// due to sharing delta writers and load stream stubs.
_close_wait(false);
RETURN_IF_ERROR(_close_wait(false));

// send CLOSE_LOAD on all incremental streams if this is the last sink.
// this must happen after all non-incremental streams are closed,
Expand All @@ -614,7 +614,7 @@ Status VTabletWriterV2::close(Status exec_status) {
}

// close_wait on all incremental streams, even if this is not the last sink.
_close_wait(true);
RETURN_IF_ERROR(_close_wait(true));

// calculate and submit commit info
if (is_last_sink) {
Expand Down Expand Up @@ -663,7 +663,7 @@ Status VTabletWriterV2::close(Status exec_status) {
return status;
}

void VTabletWriterV2::_close_wait(bool incremental) {
Status VTabletWriterV2::_close_wait(bool incremental) {
SCOPED_TIMER(_close_load_timer);
auto st = _load_stream_map->for_each_st(
[this, incremental](int64_t dst_id, LoadStreamStubs& streams) -> Status {
Expand All @@ -688,6 +688,7 @@ void VTabletWriterV2::_close_wait(bool incremental) {
if (!st.ok()) {
LOG(WARNING) << "close_wait failed: " << st << ", load_id=" << print_id(_load_id);
}
return st;
}

void VTabletWriterV2::_calc_tablets_to_commit() {
Expand Down
2 changes: 1 addition & 1 deletion be/src/vec/sink/writer/vtablet_writer_v2.h
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class VTabletWriterV2 final : public AsyncResultWriter {

void _calc_tablets_to_commit();

void _close_wait(bool incremental);
Status _close_wait(bool incremental);

void _cancel(Status status);

Expand Down

0 comments on commit d21940e

Please sign in to comment.