-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cherry-pick](branch-3.0) Pick "[Enhancement](MS) Add fix tablet data size api for meta service (#41782)" #43460
Conversation
Thank you for your contribution to Apache Doris. Check List (For Author)
Check List (For Reviewer who merge this PR)
|
run buildall |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -17,13 +17,22 @@ | |||
|
|||
#include "meta-service/meta_service_tablet_stats.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'meta-service/meta_service_tablet_stats.h' file not found [clang-diagnostic-error]
#include "meta-service/meta_service_tablet_stats.h"
^
return st; | ||
} | ||
|
||
MetaServiceResponseStatus fix_tablet_stats_internal( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'fix_tablet_stats_internal' exceeds recommended size/complexity thresholds [readability-function-size]
MetaServiceResponseStatus fix_tablet_stats_internal(
^
Additional context
cloud/src/meta-service/meta_service_tablet_stats.cpp:196: 125 lines including whitespace and comments (threshold 80)
MetaServiceResponseStatus fix_tablet_stats_internal(
^
@@ -19,6 +19,8 @@ | |||
|
|||
#include <gen_cpp/cloud.pb.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'gen_cpp/cloud.pb.h' file not found [clang-diagnostic-error]
#include <gen_cpp/cloud.pb.h>
^
run cloud_p0 |
run external |
1 similar comment
run external |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Pick #41782