Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cloud-mow) Fix sending commiting rpc to FE twice problem #41395

Merged
merged 3 commits into from
Nov 13, 2024
Merged

[fix](cloud-mow) Fix sending commiting rpc to FE twice problem #41395

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c8d2ed
[fix](cloud-mow) Fix sending commiting rpc to FE twice problem
hust-hhb Nov 7, 2024
51e3086
edit
hust-hhb Nov 7, 2024
a8f48aa
edit
hust-hhb Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,10 @@ private void commitTransaction(long dbId, List<Table> tableList, long transactio

List<OlapTable> mowTableList = getMowTableList(tableList, tabletCommitInfos);
if (!mowTableList.isEmpty()) {
// may be this txn has been calculated by previously task but commit rpc is timeout,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use BE rather than "be", it's confused with the english word "be"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhannngchen here it means may be, not BE

// and be will send another commit request to fe, so need to check txn status first
// before sending delete bitmap task to be, if txn is committed or visible, no need to
// calculate delete bitmap again, just return ok to be to finish this commit.
TransactionState transactionState = Env.getCurrentGlobalTransactionMgr()
hust-hhb marked this conversation as resolved.
Show resolved Hide resolved
.getTransactionState(dbId, transactionId);
if (null != transactionState && null != transactionState.getTransactionStatus()) {
Expand Down
Loading