[fix](cloud-mow) Fix sending commiting rpc to FE twice problem #41395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 42419 ms |
TPC-DS: Total hot run time: 192131 ms |
ClickBench: Total hot run time: 33.47 s |
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 41651 ms |
TPC-DS: Total hot run time: 193293 ms |
ClickBench: Total hot run time: 33.44 s |
zhannngchen
reviewed
Nov 8, 2024
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
Show resolved
Hide resolved
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
zhannngchen
reviewed
Nov 8, 2024
| @@ -475,6 +475,10 @@ private void commitTransaction(long dbId, List<Table> tableList, long transactio | |||
|
|
|||
| List<OlapTable> mowTableList = getMowTableList(tableList, tabletCommitInfos); | |||
| if (!mowTableList.isEmpty()) { | |||
| // may be this txn has been calculated by previously task but commit rpc is timeout, | |||
There was a problem hiding this comment.
use BE rather than "be", it's confused with the english word "be"
There was a problem hiding this comment.
@zhannngchen here it means may be, not BE
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
run performance |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Here is an expample while commit rpc will send twice: 1. first commit request try to get delete bitmap lock, there is 2 lock(fe and ms), which take over rpc timeout(60s default) but not send DELETE_BITMAP_LOCK_ERR to be, and fe will continue to send calculate delete bitmap task to be 2. be calculate delete bitmap success and remove delete bitmap cache 3. because step 1 take over 60s, be will resend commit rpc to fe 4. after first commit request done, the second commit request from step 3 will do the same thing, but delete bitmap cache has been delete by first commit, so it will fail on be 5. client will see commit fail this pr check transaction status before sending delete bitmap task to be, if transaction status is committed or visible, it no need to recalculate delete bitmap again, just retrun rpc success to be.
dataroaring
pushed a commit
that referenced
this pull request
Nov 13, 2024
…oblem (#43854) Cherry-picked from #41395 Co-authored-by: huanghaibin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an expample while commit rpc will send twice:
this pr check transaction status before sending delete bitmap task to be, if transaction status is committed or visible, it no need to recalculate delete bitmap again, just retrun rpc success to be.