[WIP] fix: 修复明细表底部存在空白行的问题 (close #2958) #2967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
linwrui
changed the title
|
@lijinke666 为啥本地没法执行测试脚本？参考贡献指南操作的
|
|
什么系统? 看起来是 Windows? Mac 未复现
试试直接运行 |
是 windows ，后面那个命令可以执行 |
5 tasks
wjgogogo
approved these changes
Nov 8, 2024
5 tasks
linwrui
changed the title
lijinke666
reviewed
Nov 14, 2024
packages/s2-core/__tests__/spreadsheet/__snapshots__/theme-spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/s2-react/__tests__/unit/components/advanced-sort/__snapshots__/index-spec.tsx.snap
Outdated
Show resolved
Hide resolved
|
@linwrui 看你改为了 WIP, 是遇到啥问题了吗, 近期会发正式版, 需要跟车的话还请尽快处理下 PR |
这个调整对布局和滚动条相关的单测影响较大，需要再看看怎么调整 |
# Conflicts: # packages/s2-core/__tests__/spreadsheet/__snapshots__/multi-line-text-spec.ts.snap # packages/s2-react/__tests__/unit/components/advanced-sort/__snapshots__/index-spec.tsx.snap # packages/s2-react/__tests__/unit/components/drill-down/__snapshots__/index-spec.tsx.snap # packages/s2-react/__tests__/unit/components/export/__snapshots__/index-spec.tsx.snap # packages/s2-react/__tests__/unit/components/header/__snapshots__/index-spec.tsx.snap # packages/s2-react/__tests__/unit/components/pagination/__snapshots__/index-spec.tsx.snap # packages/s2-react/__tests__/unit/components/sheets/__snapshots__/index-spec.tsx.snap # packages/s2-react/__tests__/unit/components/switcher/__snapshots__/index-spec.tsx.snap # packages/s2-react/__tests__/unit/components/tooltip/__snapshots__/index-spec.tsx.snap
# Conflicts: # packages/s2-core/src/facet/bbox/panel-bbox.ts
This reverts commit 36fd05d.
不知道是不是 windows 系统的问题，我直接切换到 next 支线执行 |
This reverts commit 784f858.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
我看了一下 v1 版本的滚动条是在面板之外的，所以这里应该是旧代码做了空间的预留，但是 v2的滚动条已经调整成悬浮在 panel-bbox 内，所以这里也就没必要再预留滚动条的高度了
🖼️ Screenshot
🔗 Related issue link
closes #2958 #2295
🔍 Self-Check before the merge