Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤔为什么明细表底部要有一个空白区域占位 #2958

Open
1 of 5 tasks
linwrui opened this issue Nov 5, 2024 · 3 comments · May be fixed by #2967
Open
1 of 5 tasks

🤔为什么明细表底部要有一个空白区域占位 #2958

linwrui opened this issue Nov 5, 2024 · 3 comments · May be fixed by #2967
Labels
⚡ enhancement 功能增强 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 next 2.0-next 版本的问题 ❔question 疑问/使用问题

Comments

@linwrui
Copy link
Contributor

linwrui commented Nov 5, 2024

🏷 Version

Package Version
@antv/s2 2.0.0-next.31
@antv/s2-react -
@antv/s2-vue -

Sheet Type

  • PivotSheet
  • TableSheet
  • GridAnalysisSheet
  • StrategySheet
  • EditableSheet

🖋 Description

为什么明细表底部要有一个空白区域占位？一开始我以为是给横向滚动条预留的位置，但是就算我增加列数到出现横向滚动条，底部还是固定有一小行空白
image

🔗 Reproduce Link

基础明细表 | S2
https://s2.antv.antgroup.com/examples/basic/table/#table

😊 Expected Behavior

😅 Current Behavior
@linwrui linwrui added the ❔question 疑问/使用问题 label Nov 5, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Nov 5, 2024
@lijinke666
Copy link
Member

已知问题, 透视表/明细表都有这个问题, 需要优化, 一直没来得及改, 感兴趣的话可以来个 PR.

@lijinke666 lijinke666 added the ⚡ enhancement 功能增强 label Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

你好 @linwrui，感谢你的建议, 我们会及时评估和排期, 谢谢!
当然, 如果能贡献 PR 帮助我们改进, 不胜感激！

Hello, @linwrui, thanks for your advice. We will evaluate and schedule in time. Thank you!
you could implement it by yourself through the customization capabilities provided by S2. Thanks so much for your understanding.

linwrui pushed a commit to linwrui/S2 that referenced this issue Nov 8, 2024
fix: 修复明细表底部存在空白行的问题 (antvis#2958)
fddc579
@linwrui linwrui linked a pull request Nov 8, 2024 that will close this issue
Open
16 tasks
linwrui pushed a commit to linwrui/S2 that referenced this issue Nov 8, 2024
fix: 修复明细表底部存在空白行的问题 (close antvis#2958)
05bea74
@lijinke666 lijinke666 linked a pull request Nov 8, 2024 that will close this issue
[WIP] fix: 修复明细表底部存在空白行的问题 (close #2958) #2967
Open
16 tasks
linwrui pushed a commit to linwrui/S2 that referenced this issue Nov 12, 2024
Merge remote-tracking branch 'github.com/next' into fix-antvis#2958
4ec888d
linwrui added a commit to linwrui/S2 that referenced this issue Nov 16, 2024
@linwrui
Merge remote-tracking branch 'github.com/next' into dev-fix-antvis#2958
15e349a 
# Conflicts:
#	packages/s2-core/__tests__/spreadsheet/__snapshots__/multi-line-text-spec.ts.snap
#	packages/s2-core/__tests__/spreadsheet/scroll-spec.ts
linwrui added a commit to linwrui/S2 that referenced this issue Nov 18, 2024
@linwrui
Merge remote-tracking branch 'github.com/next' into dev-fix-antvis#2958
13128cf 
# Conflicts:
#	packages/s2-core/__tests__/spreadsheet/__snapshots__/multi-line-text-spec.ts.snap
#	packages/s2-react/__tests__/unit/components/advanced-sort/__snapshots__/index-spec.tsx.snap
#	packages/s2-react/__tests__/unit/components/drill-down/__snapshots__/index-spec.tsx.snap
#	packages/s2-react/__tests__/unit/components/export/__snapshots__/index-spec.tsx.snap
#	packages/s2-react/__tests__/unit/components/header/__snapshots__/index-spec.tsx.snap
#	packages/s2-react/__tests__/unit/components/pagination/__snapshots__/index-spec.tsx.snap
#	packages/s2-react/__tests__/unit/components/sheets/__snapshots__/index-spec.tsx.snap
#	packages/s2-react/__tests__/unit/components/switcher/__snapshots__/index-spec.tsx.snap
#	packages/s2-react/__tests__/unit/components/tooltip/__snapshots__/index-spec.tsx.snap
linwrui added a commit to linwrui/S2 that referenced this issue Nov 20, 2024
@linwrui
Merge remote-tracking branch 'github.com/next' into dev-fix-antvis#2958
a2e8178 
# Conflicts:
#	packages/s2-core/src/facet/bbox/panel-bbox.ts
linwrui pushed a commit to linwrui/S2 that referenced this issue Nov 21, 2024
Merge remote-tracking branch 'github.com/next' into dev-fix-antvis#2958
4c0fe5e
linwrui pushed a commit to linwrui/S2 that referenced this issue Nov 21, 2024
Merge remote-tracking branch 'github.com/next' into dev-fix-antvis#2958
5dd3b00
linwrui added a commit to linwrui/S2 that referenced this issue Nov 23, 2024
@linwrui
Merge remote-tracking branch 'github.com/next' into dev-fix-antvis#2958
b74bae9
linwrui added a commit to linwrui/S2 that referenced this issue Dec 1, 2024
@linwrui
Merge remote-tracking branch 'github.com/next' into dev-fix-antvis#2958
3db870a
@github-actions github-actions bot added the 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 label Dec 16, 2024
@ouzhou
Copy link

ouzhou commented Dec 16, 2024

@lijinke666 而且只有滚动到底部才会有border-bottom， 看起来就像是缺了一个边框一样

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚡ enhancement 功能增强 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 next 2.0-next 版本的问题 ❔question 疑问/使用问题
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] fix: 修复明细表底部存在空白行的问题 (close #2958) linwrui/S2
3 participants
@ouzhou @lijinke666 @linwrui