Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复自定义目录树同名节点展示异常 & 导出缺失角头 close #2455 #2551

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Feb 19, 2024

👀 PR includes

🐛 Bugfix

📝 Description

  • 自定义行列头使用 field 生成 id, 解决同名节点引起的交互/折叠/复制等衍生问题.
- "root[&]自定义节点A"
+ "root[&]custom-node-1"
  • 兼容刷选和复制导出, 并完善相关单测.
  • 修复自定义行头 (平铺/树状) 复制的数据未包含角头的问题.

🖼️ Screenshot

Before After
Kapture 2024-02-19 at 19 05 29 Kapture 2024-02-19 at 19 03 34
image image
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Feb 20, 2024 8:20am

@github-actions github-actions bot added the pr(fix) bug fix label Feb 19, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Size Change: -357 B (0%)

Total Size: 317 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 222 kB +142 B (0%)
./packages/s2-react/dist/index.min.js 69.3 kB -499 B (-1%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/style.min.css 4.01 kB
./packages/s2-vue/dist/index.min.js 20.2 kB
./packages/s2-vue/dist/style.min.css 1.98 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Feb 19, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Feb 19, 2024
@lijinke666 lijinke666 changed the title fix: 修复自定义目录树同名节点展示异常 close #2455 fix: 修复自定义目录树同名节点展示异常 & 导出缺失角头 close #2455 Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ecdc9c8) 75.77% compared to head (208acae) 78.41%.
Report is 250 commits behind head on next.

Files Patch % Lines
...core/src/utils/export/copy/pivot-data-cell-copy.ts 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2551      +/-   ##
==========================================
+ Coverage   75.77%   78.41%   +2.64%     
==========================================
  Files         257      275      +18     
  Lines       11994    12516     +522     
  Branches     2464     2557      +93     
==========================================
+ Hits         9088     9814     +726     
+ Misses       1398     1146     -252     
- Partials     1508     1556      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit 6d315bf into next Feb 23, 2024
12 of 13 checks passed
@lijinke666 lijinke666 deleted the fix-2455 branch February 23, 2024 02:41
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants