Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 自定义目录树的tooltip显示和折叠的rowKey有问题 #2455

Closed
4 tasks
oliver34 opened this issue Dec 7, 2023 · 6 comments
Closed
4 tasks

🐛 自定义目录树的tooltip显示和折叠的rowKey有问题 #2455

oliver34 opened this issue Dec 7, 2023 · 6 comments
Assignees
Labels
🐛 bug 这个是一个 bug 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 released on @next ✨ supported or fixed in 2.x 在 2.x 版本中,已支持该需求,或 bug 已修复

Comments

@oliver34
Copy link

oliver34 commented Dec 7, 2023

🏷 Version

Package Version
@antv/s2 1.52.1
@antv/s2-react 1.44.3
@antv/s2-vue

Sheet Type

✅ PivotSheet

  • TableSheet
  • GridAnalysisSheet
  • StrategySheet
  • EditableSheet

🖋 Description

自定义目录树存在两个问题:

  1. 如果两个树的父节点的title一样,那么一个折叠另一个也会折叠,而不是根据key来的
  2. 默认tooltip展示的又是节点的key,而不是title

具体看截图,下面有codesandbox 链接
image
image

⌨️ Code Snapshots

🔗 Reproduce Link

https://codesandbox.io/p/sandbox/old-currying-p3xz89?file=%2Findex.tsx

🤔 Steps to Reproduce

😊 Expected Behavior

希望折叠的根据key来做唯一标识,tooltip展示title

😅 Current Behavior

💻 System information

Environment Info
System
Browser
@wjgogogo wjgogogo added the 🐛 bug 这个是一个 bug label Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

你好 @oliver34,很抱歉给你带来了不好的体验, 我们会尽快排查问题并修复, 请关注后续发布日志.

Hello, @oliver34, We are so sorry for the bad experience. We will troubleshoot and fix the problem as soon as possible. Please pay attention to the follow-up change logs.

@lijinke666
Copy link
Member

lijinke666 commented Dec 12, 2023

如果两个树的父节点的title一样,那么一个折叠另一个也会折叠,而不是根据key来的

问题1, 确实 1.x, 2.x 都有问题. 由于改动影响面较大, 会在 2.x 重构解决, 目前 1.x 临时解决方案可以给同名节点增加空格规避

- title: '节点 A'
+ title: '节点 A '

默认tooltip展示的又是节点的key,而不是title

问题 2, 在 2.0 版本中已修复, 1.x 临时解决方案可以增加格式化

const s2DataConfig = {
	fields: {
	    meta: [
	      {
	        field: 'custom-node-1',
	        name: '节点 A',
	      },
	    ]
	  }
}

@lijinke666 lijinke666 added the ✨ supported or fixed in 2.x 在 2.x 版本中,已支持该需求,或 bug 已修复 label Dec 12, 2023
Copy link
Contributor

你好 @oliver34,该功能或缺陷已经在 2.0 next 版本 中支持或修复,next 版本目前处于内测中, 感谢你的支持与理解。

如有任何 2.0 版本 问题,请前往讨论区,正式版预计年底发布 (文档施工中 🚧), 抢先试用:

yarn add @antv/s2@next
yarn add @antv/s2-react@next
yarn add @antv/s2-vue@next

Hello, @oliver34, This feature or flaw has been supported or fixed in 2.0 next version, next version is currently in private beta, thank you for your support and understanding.

Any 2.0 version issues, please go to discussion, which released the official version is expected to the end (document 🚧) during construction, the first trial:

@github-actions github-actions bot added the 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 label Jan 16, 2024
@lijinke666 lijinke666 self-assigned this Feb 5, 2024
lijinke666 added a commit that referenced this issue Feb 23, 2024
* fix: 修复自定义目录树同名节点展示异常 close #2455

* fix: 修复自定义行头导出时角头缺失

* fix: 使用 antd 新版的 meassure 的用法

* test: 修复单测

* test: 修复单测
@lijinke666
Copy link
Member

fixed #2551

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-v2.0.0-next.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-react-v2.0.0-next.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug 这个是一个 bug 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 released on @next ✨ supported or fixed in 2.x 在 2.x 版本中,已支持该需求,或 bug 已修复
Projects
None yet
Development

No branches or pull requests

3 participants