Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复隐藏列总计时行总计也被隐藏问题 #2417

Merged
merged 4 commits into from
Nov 17, 2023

fix: optimize test case

dcd0487
Select commit
Loading
Failed to load commit list.
Merged

fix: 修复隐藏列总计时行总计也被隐藏问题 #2417

fix: optimize test case
dcd0487
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 17, 2023 in 0s

76.74% (+0.26%) compared to 1adc25d

View this Pull Request on Codecov

76.74% (+0.26%) compared to 1adc25d

Details

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (1adc25d) 76.48% compared to head (dcd0487) 76.74%.
Report is 90 commits behind head on master.

Files Patch % Lines
packages/s2-core/src/data-set/pivot-data-set.ts 72.85% 2 Missing and 17 partials ⚠️
packages/s2-core/src/facet/pivot-facet.ts 81.63% 1 Missing and 8 partials ⚠️
packages/s2-core/src/utils/text.ts 50.00% 7 Missing ⚠️
...mponents/sheets/editable-sheet/edit-cell/index.tsx 50.00% 5 Missing and 1 partial ⚠️
...s/s2-core/src/facet/layout/build-gird-hierarchy.ts 85.29% 1 Missing and 4 partials ⚠️
packages/s2-core/src/facet/layout/layout-hooks.ts 0.00% 3 Missing and 1 partial ⚠️
...act/src/components/sheets/editable-sheet/index.tsx 33.33% 3 Missing and 1 partial ⚠️
packages/s2-core/src/facet/base-facet.ts 85.71% 0 Missing and 3 partials ⚠️
...nteraction/brush-selection/base-brush-selection.ts 70.00% 2 Missing and 1 partial ⚠️
packages/s2-core/src/utils/export/copy.ts 85.00% 0 Missing and 3 partials ⚠️
... and 25 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2417      +/-   ##
==========================================
+ Coverage   76.48%   76.74%   +0.26%     
==========================================
  Files         240      241       +1     
  Lines       12312    12602     +290     
  Branches     2630     2708      +78     
==========================================
+ Hits         9417     9672     +255     
+ Misses       1377     1350      -27     
- Partials     1518     1580      +62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov