Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复隐藏列总计时行总计也被隐藏问题 #2417

Merged
merged 4 commits into from
Nov 17, 2023

fix: optimize test case

dcd0487
Select commit
Loading
Failed to load commit list.
Merged

fix: 修复隐藏列总计时行总计也被隐藏问题 #2417

fix: optimize test case
dcd0487
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 17, 2023 in 1s

76.58% of diff hit (target 76.48%)

View this Pull Request on Codecov

76.58% of diff hit (target 76.48%)

Annotations

Check warning on line 66 in packages/s2-core/src/cell/corner-cell.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/cell/corner-cell.ts#L66 

Added line #L66 was not covered by tests

Check warning on line 122 in packages/s2-core/src/cell/data-cell.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/cell/data-cell.ts#L121-L122 

Added lines #L121 - L122 were not covered by tests

Check warning on line 105 in packages/s2-core/src/cell/header-cell.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/cell/header-cell.ts#L105 

Added line #L105 was not covered by tests

Check warning on line 573 in packages/s2-core/src/data-set/pivot-data-set.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/data-set/pivot-data-set.ts#L573 

Added line #L573 was not covered by tests

Check warning on line 587 in packages/s2-core/src/data-set/pivot-data-set.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/data-set/pivot-data-set.ts#L587 

Added line #L587 was not covered by tests

Check warning on line 35 in packages/s2-core/src/facet/layout/build-gird-hierarchy.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/facet/layout/build-gird-hierarchy.ts#L35 

Added line #L35 was not covered by tests

Check warning on line 46 in packages/s2-core/src/facet/layout/layout-hooks.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/facet/layout/layout-hooks.ts#L46 

Added line #L46 was not covered by tests

Check warning on line 50 in packages/s2-core/src/facet/layout/layout-hooks.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/facet/layout/layout-hooks.ts#L49-L50 

Added lines #L49 - L50 were not covered by tests

Check warning on line 571 in packages/s2-core/src/facet/pivot-facet.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/facet/pivot-facet.ts#L571 

Added line #L571 was not covered by tests

Check warning on line 79 in packages/s2-core/src/interaction/base-interaction/click/data-cell-click.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/interaction/base-interaction/click/data-cell-click.ts#L79 

Added line #L79 was not covered by tests

Check warning on line 88 in packages/s2-core/src/interaction/base-interaction/click/data-cell-click.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/interaction/base-interaction/click/data-cell-click.ts#L88 

Added line #L88 was not covered by tests

Check warning on line 47 in packages/s2-core/src/interaction/base-interaction/hover.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/interaction/base-interaction/hover.ts#L47 

Added line #L47 was not covered by tests

Check warning on line 434 in packages/s2-core/src/interaction/brush-selection/base-brush-selection.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/interaction/brush-selection/base-brush-selection.ts#L433-L434 

Added lines #L433 - L434 were not covered by tests

Check warning on line 54 in packages/s2-core/src/interaction/range-selection.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/interaction/range-selection.ts#L54 

Added line #L54 was not covered by tests

Check warning on line 16 in packages/s2-core/src/interaction/row-column-resize.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/interaction/row-column-resize.ts#L16 

Added line #L16 was not covered by tests

Check warning on line 302 in packages/s2-core/src/utils/text.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/utils/text.ts#L301-L302 

Added lines #L301 - L302 were not covered by tests

Check warning on line 309 in packages/s2-core/src/utils/text.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/utils/text.ts#L308-L309 

Added lines #L308 - L309 were not covered by tests

Check warning on line 313 in packages/s2-core/src/utils/text.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/utils/text.ts#L312-L313 

Added lines #L312 - L313 were not covered by tests

Check warning on line 319 in packages/s2-core/src/utils/text.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-core/src/utils/text.ts#L319 

Added line #L319 was not covered by tests

Check warning on line 15 in packages/s2-react/src/components/sheets/editable-sheet/drag-copy/index.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/index.tsx#L15 

Added line #L15 was not covered by tests

Check warning on line 129 in packages/s2-react/src/components/sheets/editable-sheet/drag-copy/index.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/index.tsx#L129 

Added line #L129 was not covered by tests

Check warning on line 42 in packages/s2-react/src/components/sheets/editable-sheet/edit-cell/index.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-react/src/components/sheets/editable-sheet/edit-cell/index.tsx#L42 

Added line #L42 was not covered by tests

Check warning on line 101 in packages/s2-react/src/components/sheets/editable-sheet/edit-cell/index.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-react/src/components/sheets/editable-sheet/edit-cell/index.tsx#L100-L101 

Added lines #L100 - L101 were not covered by tests

Check warning on line 105 in packages/s2-react/src/components/sheets/editable-sheet/edit-cell/index.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-react/src/components/sheets/editable-sheet/edit-cell/index.tsx#L104-L105 

Added lines #L104 - L105 were not covered by tests

Check warning on line 14 in packages/s2-react/src/components/sheets/editable-sheet/index.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/s2-react/src/components/sheets/editable-sheet/index.tsx#L12-L14 

Added lines #L12 - L14 were not covered by tests
View more details on Codecov