Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read or write to event attributes with dynamically alloc'd keys #3174

Closed
wants to merge 111 commits into from

Changelog for #3174

1d05270
Select commit
Loading
Failed to load commit list.
Closed

Read or write to event attributes with dynamically alloc'd keys #3174

Changelog for #3174
1d05270
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 6, 2024 in 1s

59.62% (+0.21%) compared to ea843f7

View this Pull Request on Codecov

59.62% (+0.21%) compared to ea843f7

Details

Codecov Report

Attention: Patch coverage is 62.28518% with 812 lines in your changes are missing coverage. Please review.

Project coverage is 59.62%. Comparing base (ea843f7) to head (1d05270).
Report is 21 commits behind head on main.

Files Patch % Lines
crates/ibc/src/event.rs 46.94% 113 Missing ⚠️
crates/events/src/extend.rs 68.00% 104 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 88 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs 14.13% 79 Missing ⚠️
crates/governance/src/event.rs 52.21% 54 Missing ⚠️
crates/events/src/lib.rs 71.59% 50 Missing ⚠️
crates/events/src/extend/dynamic.rs 61.22% 38 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 32 Missing ⚠️
crates/state/src/wl_state.rs 0.00% 30 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 29.41% 24 Missing ⚠️
... and 26 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3174      +/-   ##
==========================================
+ Coverage   59.41%   59.62%   +0.21%     
==========================================
  Files         298      304       +6     
  Lines       92326    93379    +1053     
==========================================
+ Hits        54853    55681     +828     
- Misses      37473    37698     +225

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov